Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Body part names refactor #37807

Merged
merged 3 commits into from
Feb 7, 2020
Merged

Conversation

Qrox
Copy link
Contributor

@Qrox Qrox commented Feb 7, 2020

Summary

SUMMARY: None

Purpose of change

Use translation for body part names, but do not merge name_plural and name into a single object. Closes #37697, closes #37700.

Describe the solution

  1. Renamed bodypart name variables to reflect their actual function.
  2. Added comments to explain why name_plural and name are not merged into a single object.
  3. Used translation for bodypart names.
  4. Updated the string extraction script and the documentation

Testing

Started game and opened character info menu and armor sorting menu, and bodypart names were displayed correctly.

Additional context

Copied from the comments:

    // This is NOT the plural of `name`; it's a name refering to the pair of
    // bodyparts which this bodypart belongs to, and thus should not be implemented
    // using "ngettext" or "translation::make_plural". Otherwise, in languages
    // without plural forms, translation of this string would indicate it
    // to be a left or right part, while it is not.

@ZhilkinSerg ZhilkinSerg added Translation I18n [C++] Changes (can be) made in C++. Previously named `Code` [JSON] Changes (can be) made in JSON [Python] Code made in Python labels Feb 7, 2020
@ZhilkinSerg ZhilkinSerg merged commit 63798be into CleverRaven:master Feb 7, 2020
@Qrox Qrox deleted the bodypart-names branch February 15, 2020 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[C++] Changes (can be) made in C++. Previously named `Code` [JSON] Changes (can be) made in JSON [Python] Code made in Python Translation I18n
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Name as an object not supported for body_part type
2 participants