No more 1900+kcal sauteed fiddleheads #37779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
February 6, 2020 12:09
Sauteed fiddleheads were never meant to have 1900+ kcal. Forcing the use of cooking oil or butter brings their range of calories back into reasonable levels.
Fixing style
fengjixuchui
added a commit
to fengjixuchui/Cataclysm-DDA
that referenced
this pull request
Feb 7, 2020
Merge pull request CleverRaven#37779 from ashGlaw/Fix-Sauteed-Fiddleh…
This was referenced Feb 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Bugfixes "Fixed making sauteed fiddleheads with fat, lard, or tallow"Purpose of change
When fiddleheads were added it made sense to let any fat be used to saute them. I didn't understand the inheritance of neutrition. Now I have a much firmer grasp of the systems involved, and it was a mistake to ever let fat, tallow, or lard be interchangeable with butter or cooking oil in a recipe. 1900+ Kcal for a veggy dish is just absurd.
Describe the solution
I changed the recipe to restrict the fats used to cooking oil 1 & 2 and any butter.
Describe alternatives you've considered
It was suggested that I could have a version of the recipe that makes sauteed fiddleheads with fat, but only uses one unit of cooking oil, returning the rest of the mass of the fat as cracklins and cooking oil as a byproduct. I think that could work, but it would still be very messy. Just putting the extra step of rendering the fat into cooking oil as a separate recipe seems much more streamlined.
Testing
I loaded a fresh world, cheated my skills up, spawned the necessary tools and components, crafted the recipes, and ate the results. Everything worked. The recipes display properly, and I tested if I could still use fat - I could not.
Additional context
Glad I can bring this more in line with the rest of the systems