Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update explosives to use corrrect explosive power, casing mass, and fragment mass. #37710

Merged
merged 5 commits into from
Feb 21, 2020

Conversation

Brian-Otten
Copy link
Contributor

@Brian-Otten Brian-Otten commented Feb 4, 2020

Summary

SUMMARY: Balance "Makes explosives use correct values"

Purpose of change

Many explosives had nonsensical (or slightly off) values for their explosive power, casing mass, and fragment mass.

Describe the solution

Go over all the bombs and give them correct values.
Explosive power is grams of tnt equivalent.
Casing mass is the weight of all the items that make up the casing, or a value that matches the items weight if some of it is discarded (pipe bomb).
Fragment mass is the weight of a nail for items that use nails as fragments (0.8g), and higher than that for explosives with no method of causing extra fragmentation.

Describe alternatives you've considered

Wait for consensus on #37705 and leave the values all wacky until then.

Testing

Game loads and items have the correct values.

@ZhilkinSerg ZhilkinSerg added [JSON] Changes (can be) made in JSON Game: Balance Balancing of (existing) in-game features. labels Feb 5, 2020
Change fragment from nailbombs to 0.4g (half a nail)
And change to 1g from 2g for fragmenting metal bombs.
@Brian-Otten
Copy link
Contributor Author

Brian-Otten commented Feb 11, 2020

Adjusted so bombs with nails have fragments the size of half a nail (0.4g), and bombs where the casing fragments now have 1g fragments, after some review from kevin on discord.

@I-am-Erk
Copy link
Member

It's tough to review this. Could you summarize the rationale behind the changes you picked?

Accidentally included gallon jug to casing mass
@Brian-Otten
Copy link
Contributor Author

For explosive power i used the grams of black powder used in the recipe, x 0.55, to get tnt equivalence. Some of the other ingredients are not correctly proportioned in comparison to black powder for tnt equivalence, but that is being fixed in other PR's i have open currently. I rounded down slightly for round numbers to match the other explosives in game.

So for the black powder charge, it takes 4120 black powder, which is 2266 grams of tnt equivalent, which i rounded to 2250 explosive power.

For the casing on the black powder charge, we see that 20 scrap metal is included, with a weight of 2kg, since that is going to make up the fragment released from the blast we get a casing mass of 2000g.

The main thing that is up for discussion is the fragment size. As mentioned above, i'm now using half a nail as the fragment size for bombs that use nails as their fragments (0.4g), and 1g fragments for bombs with larger metal objects being fragmented by the blast themselves.

If you want to audit that i got it right, go through the ones i changed and compare explosive power to black powder used in the recipe, and compare casing mass to the weight of the metal ingredients used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Game: Balance Balancing of (existing) in-game features. [JSON] Changes (can be) made in JSON
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants