Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] body part Name to object, double have decimal #37698

Closed
wants to merge 1 commit into from
Closed

[WIP] body part Name to object, double have decimal #37698

wants to merge 1 commit into from

Conversation

snipercup
Copy link
Contributor

Summary

SUMMARY: none

Purpose of change

Contributes to #36611 and #36110

Describe the solution

Change name to object
Remove name_plural
Doubles have decimals now

Describe alternatives you've considered

doing something about lagacy_id but im not sure if it is used. #15070 seems to suggest it is obsolete

Testing

Cannot test untill #37697 is resolved

@snipercup snipercup changed the title body part Name to object, double have decimal [WIP] body part Name to object, double have decimal Feb 4, 2020
@ZhilkinSerg ZhilkinSerg added the [JSON] Changes (can be) made in JSON label Feb 4, 2020
@@ -68,8 +68,7 @@
{
"id": "arm_l",
"type": "body_part",
"name": "left arm",
"name_plural": "arms",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This wasn't changed to the new format, because it doesn't actually use the new format: "name_plural" here means the name for a pair of body parts, and was only named "name_plural" because it was (incorrectly) implemented as a plural name. If this is to be changed, the proper change would be renaming it from "name_plural" to something like "name_pair".

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for clearing that up. I have no issue with it remaining as it is, but we might run into the same problem when someone else is looking for name_plural in the files and tries to change it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We would probably like more than two body parts maximum eventually, so using name_plural could be okay.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It prevents proper translation of the plural name in languages without plurals (such as Chinese).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm... What about other plural strings (like item names)? Are they not translatable to these languages too?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Item names are fine becasue the plural string is the exact plural form of the singlular string. But here it's not the case: the exact plural form of "left arm" is "left arms", and the exact singular form of "arms" is "arm". If we translate "left arm" and "arms" to a single string in languages without plural forms, the result is that we either translate "arms" to "left arms", or translate "left arm" to "arm", which do not make sense in many contexts such as the encumberance menu and amor sorting menu.

To clarify it let me give an example in Chinese:
If we translate the two strings separately:

left arm -> 左(left)臂(arm)
arms     -> 手臂(arms)

But if we treat them as singular and plural forms:

left arm / arms -> 左(left)臂(arm(s))

or

left arm / arms -> 手臂(arm(s))

That said, if gettext and Transifex has the functionality to override the plural settings of a language for a specific string, then we can treat these strings as singular and plural forms. Otherwise, we need to specify them separately.

@snipercup
Copy link
Contributor Author

Closed in favor of #37700

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[JSON] Changes (can be) made in JSON
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants