Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add shot counter to mods and gun #37693

Merged
merged 1 commit into from Mar 6, 2020
Merged

Add shot counter to mods and gun #37693

merged 1 commit into from Mar 6, 2020

Conversation

ghost
Copy link

@ghost ghost commented Feb 4, 2020

Summary

SUMMARY: Features "Add shot counter to mods and gun"

Purpose of change

@tenmillimaster wanted suppressors to count the number of shots put through them instead of having a flat RNG to break. so this enables that, also adds the counter to the gun itself and all its mods, incase that is needed for other plans he has in that area.

Describe the solution

Just put an item var on the gun and its mods everytim eits fired, storing the number of rounds fired.

Describe alternatives you've considered

N/A

Testing

output print for the number, and checked the item var serialized and deserialized ok, it did.,

Additional context

N/A

@ZhilkinSerg ZhilkinSerg added 0.E Feature Freeze [C++] Changes (can be) made in C++. Previously named `Code` Items / Item Actions / Item Qualities Items and how they work and interact Ranged Ranged (firearms, bows, crossbows, throwing), balance, tactics labels Feb 4, 2020
@Rail-Runner
Copy link
Contributor

Why not track number of shots only on gunmods with a certain flag? I think it's not necessary to track this for all gunmods.

@ZhilkinSerg ZhilkinSerg changed the base branch from master to dev March 6, 2020 10:47
@ZhilkinSerg ZhilkinSerg merged commit ed7777e into CleverRaven:dev Mar 6, 2020
@ZhilkinSerg ZhilkinSerg mentioned this pull request Mar 6, 2020
13 tasks
ZhilkinSerg pushed a commit that referenced this pull request Mar 15, 2020
ZhilkinSerg pushed a commit that referenced this pull request Mar 16, 2020
ZhilkinSerg pushed a commit that referenced this pull request Mar 17, 2020
ZhilkinSerg pushed a commit that referenced this pull request Mar 17, 2020
ZhilkinSerg pushed a commit that referenced this pull request Mar 18, 2020
ZhilkinSerg pushed a commit that referenced this pull request Mar 29, 2020
ZhilkinSerg pushed a commit that referenced this pull request Apr 1, 2020
ZhilkinSerg pushed a commit that referenced this pull request Apr 1, 2020
ZhilkinSerg pushed a commit that referenced this pull request Apr 2, 2020
ZhilkinSerg pushed a commit that referenced this pull request Apr 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[C++] Changes (can be) made in C++. Previously named `Code` Items / Item Actions / Item Qualities Items and how they work and interact Ranged Ranged (firearms, bows, crossbows, throwing), balance, tactics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants