-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add shot counter to mods and gun #37693
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZhilkinSerg
added
0.E Feature Freeze
[C++]
Changes (can be) made in C++. Previously named `Code`
Items / Item Actions / Item Qualities
Items and how they work and interact
Ranged
Ranged (firearms, bows, crossbows, throwing), balance, tactics
labels
Feb 4, 2020
Why not track number of shots only on gunmods with a certain flag? I think it's not necessary to track this for all gunmods. |
This was referenced Feb 9, 2020
ZhilkinSerg
pushed a commit
that referenced
this pull request
Mar 15, 2020
ZhilkinSerg
pushed a commit
that referenced
this pull request
Mar 16, 2020
ZhilkinSerg
pushed a commit
that referenced
this pull request
Mar 17, 2020
ZhilkinSerg
pushed a commit
that referenced
this pull request
Mar 17, 2020
ZhilkinSerg
pushed a commit
that referenced
this pull request
Mar 18, 2020
ZhilkinSerg
pushed a commit
that referenced
this pull request
Mar 29, 2020
ZhilkinSerg
pushed a commit
that referenced
this pull request
Apr 1, 2020
ZhilkinSerg
pushed a commit
that referenced
this pull request
Apr 1, 2020
ZhilkinSerg
pushed a commit
that referenced
this pull request
Apr 2, 2020
ZhilkinSerg
pushed a commit
that referenced
this pull request
Apr 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[C++]
Changes (can be) made in C++. Previously named `Code`
Items / Item Actions / Item Qualities
Items and how they work and interact
Ranged
Ranged (firearms, bows, crossbows, throwing), balance, tactics
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Features "Add shot counter to mods and gun"
Purpose of change
@tenmillimaster wanted suppressors to count the number of shots put through them instead of having a flat RNG to break. so this enables that, also adds the counter to the gun itself and all its mods, incase that is needed for other plans he has in that area.
Describe the solution
Just put an item var on the gun and its mods everytim eits fired, storing the number of rounds fired.
Describe alternatives you've considered
N/A
Testing
output print for the number, and checked the item var serialized and deserialized ok, it did.,
Additional context
N/A