Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blind firing at unseen targets won't show info about hits and "Really attack?" query #37664

Merged
merged 2 commits into from
Feb 3, 2020
Merged

Blind firing at unseen targets won't show info about hits and "Really attack?" query #37664

merged 2 commits into from
Feb 3, 2020

Conversation

Night-Pryanik
Copy link
Contributor

Summary

SUMMARY: Interface "Blind firing at unseen targets won't show info about hits and "Really attack?" query."

Purpose of change

Firing at unseen targets should not show you messages like "Good hit" or "Critical!".
Firing at unseen non-hostile NPCs should not show you "Really attack?" query.

Describe the solution

Added check for visibility of targets prior to printing messages and queries.

Describe alternatives you've considered

None.

Testing

  • Fired at tile which unseen debug monster stands on - no more messages like "Good hit" or "Critical!".
  • Fired at tile which unseen non-hostile NPC stands on - no more "Really attack?" query.

Additional context

None.

@Night-Pryanik Night-Pryanik added Info / User Interface Game - player communication, menus, etc. Ranged Ranged (firearms, bows, crossbows, throwing), balance, tactics labels Feb 3, 2020
@ZhilkinSerg ZhilkinSerg merged commit b9afd7d into CleverRaven:master Feb 3, 2020
@Night-Pryanik Night-Pryanik deleted the blind-firing-tweaks branch February 3, 2020 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Info / User Interface Game - player communication, menus, etc. Ranged Ranged (firearms, bows, crossbows, throwing), balance, tactics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants