Add the option to display ascii art in item description

[Fris0uman]

Summary

SUMMARY: Interface "Add the option to display ascii art in item description"

Purpose of change

Add the option to display ascii art in item description. The option is on by default, can be turned off in settings>options>graphics

Describe the solution

Add one optional string entry "ascii_picture" to items
Display the ascii art at the bottom of the item description
If a line is longer than 42 char throw an error and truncate it

Describe alternatives you've considered

Testing

Using the balloon ascii that is too big to fit:

"ascii_picture": [
      "        ,,,,,,,,,,,,,",
      "    .;;;;;;;;;;;;;;;;;;;,.",
      " .;;;;;;;;;;;;;;;;;;;;;;;;,",
      ".;;;;;;;;;;;;;;;;;;;;;;;;;;;;.",
      "<color_red>;;;;;@;;;;;;;;;;;;;;;;;;;;;;;;</color>' .............",
      ";;;;@@;;;;;;;;;;;;;;;;;;;;;;;;'.................",
      ";;;;@@;;;;;;;;;;;;;;;;;;;;;;;;'...................`",
      ";;;;@;;;;;;;;;;;;;;;@;;;;;;;'.....................",
      " `;;;;;;;;;;;;;;;;;;;@@;;;;;'..................;....",
      "   `;;;;;;;;;;;;;;;;@@;;;;'....................;;...",
      "     `;;;;;;;;;;;;;@;;;;'...;.................;;....",
      "        `;;;;;;;;;;;;'   ...;;...............;.....",
      "           `;;;;;;'        ...;;..................",
      "              ;;              ..;...............",
      "              `                  ............",
      "             `                      ......",
      "             `                         ..",
      "           `                           '",
      "          `                           '",
      "         `                           '",
      "        `                           `",
      "        `                           `,",
      "        `",
      "         `",
      "           `."
    ],

From the inventory:

Additional context

This would only add the option to put ascii art in the item not the art itself.

[kevingranade]

This pull request has been mentioned on Cataclysm: Dark Days Ahead. There might be relevant details there:

https://discourse.cataclysmdda.org/t/ascii-art-in-item-description/19462/31

[esotericist]

So in addition to the feedback I already gave you (this should be an array of strings instead of a string with line endings in it)
I would recommend adding something in the doc folder, presumably in one of the json-related files, about how this works, what it's intended for, and useful information on typical line lengths

[Qrox]

I think you can add a flag to item_info to trim the line in the display code when it's too long. (And perhaps also a new hotkey to show a popup to display the full ascii art).

[esotericist]

Truncating the lines based on the width of the display is a good idea. Adding a keypress to bring up the full thing is a little more awkward, because you'd have to make sure you get it in all of the relevant contexts (and there's several).

I think get the truncation in, and key bindings can happen in a future PR (if they happen at all).

[esotericist]

While an example is good, I definitely think we want to mention what the typical line widths are in the common interfaces so that artists don't have to guess at whether or not their design will fit.

[codemime]

You can't really use neither length nor substr here. These functions consider string length in terms of bytes, but the string is actually in UTF-8 (multi-byte encoding) and can also contain tags. Use utf8_width and remove_color_tags to get the actual "printable" length of the string.

42 is a magic number (quite famous, but still magic). Use a named constant instead.