Fix stacks of ammo giving one round of components

[Rogal-Dorn]

Summary

SUMMARY: Bugfixes "Multiply components received from disassembling ammunition by its stack size so that 29/30 cases don't disappear"

Purpose of change

Fixes #37345
A change to ammunition disassembly required a stack to disassemble any ammunition but did not increase the resulting resources gained.

Describe the solution

This PR is a series of .json edits to make the results what was expected. For example

[
  {
    "result": "10mm_fmj",
    "type": "uncraft",
    "time": "5 s",
    "qualities": [ { "id": "PULL", "level": 1 } ],
    "components": [ [ [ "lead", 2 ] ], [ [ "10mm_casing", 1 ] ], [ [ "smpistol_primer", 1 ] ], [ [ "gunpowder_magnum_pistol", 5 ] ] ],
    "flags": [ "UNCRAFT_SINGLE_CHARGE" ]
  }
]

was changed to

[
  {
    "result": "10mm_fmj",
    "type": "uncraft",
    "time": "5 s",
    "qualities": [ { "id": "PULL", "level": 1 } ],
    "components": [ [ [ "lead", 80 ] ], [ [ "10mm_casing", 40 ] ], [ [ "smpistol_primer", 40 ] ], [ [ "gunpowder_magnum_pistol", 200 ] ] ],
    "flags": [ "UNCRAFT_SINGLE_CHARGE" ]
  }
]

as the stack_size value is 40.

Describe alternatives you've considered

Multiplying the results by the stack size, although this would require c++ changes and I don't understand the systems involved.

Testing

Spawned several stacks of different ammunition and a kinetic bullet puller and disassembled them, resulting in the correct amount of components.

Additional context

[Soup-de-Loop]

Ack commented wrong. Please ignore this.

[Soup-de-Loop]

Here it's just expecting you to put it through the linter because the line has become too long with the numbers increasing. It's expecting

[
  {
    "result": "38super_fmj",
    "type": "uncraft",
    "skill_used": "gun",
    "difficulty": 5,
    "time": "5 s",
    "qualities": [ { "id": "PULL", "level": 1 } ],
    "components": [
      [ [ "lead", 80 ] ],
      [ [ "38super_casing", 40 ] ],
      [ [ "smpistol_primer", 40 ] ],
      [ [ "gunpowder_magnum_pistol", 120 ] ]
    ],
    "flags": [ "UNCRAFT_SINGLE_CHARGE" ]
  }
]

[Rogal-Dorn]

Thanks for letting me know! I used your correction there and I'll make sure to follow any further errors when I wake up.

[Rogal-Dorn]

I've found out .454 Casull behaves as if it has a stack_size value of 20, despite the 454.json file under items/ammo showing it's 15.

I don't believe this is directly related to this PR, and changing the uncraft 454.json to reflect a stack_size of 20 seems like a bad move since the two files would be based off different numbers.

[Rogal-Dorn]

I've found out .454 Casull behaves as if it has a stack_size value of 20, despite the 454.json file under items/ammo showing it's 15.

I don't believe this is directly related to this PR, and changing the uncraft 454.json to reflect a stack_size of 20 seems like a bad move since the two files would be based off different numbers.

Apparently the "count" variable is the one that should be used, and not the stack_size. I will correct this in cases where they differ.

[Rogal-Dorn]

I've been informed this fix won't be acceptable due to changes in the count variable not being considered. Closing.