Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Bio magnet description and on-hit messages #35255

Merged
merged 2 commits into from
Nov 3, 2019

Conversation

Fris0uman
Copy link
Contributor

@Fris0uman Fris0uman commented Nov 2, 2019

Summary

SUMMARY: Bugfixes "Fix Bio magnet description and on-hit messages"

Purpose of change

Fixes #29745, fix Bio magnet description and on-hit messages:

  • When hitting an enemy using the magnet you get a log message
  • Description of the CBM does say that your own strength is involved in the process

Describe the solution

  • add proper argument to projectile_attack
  • edit description

Describe alternatives you've considered

Replace the useage of weight_capacitywith an hardcoded value, it doesn't make muc hsens for the weight of object the magnet can affect to depend on your weight_capacity

Following that ref http://www.walkermagnet.com/scrap-magnets-liftmaster-lm-cast-series.htm used in #34456 the cap could be 544 kg. But the smaller magnet in that link is 122cm in diameter and weight about 1225 kg (if my convertions from imperial are correct) so it's doubtfull something like this could fit in a hand.

Alternatively we could compute the strength of the magnet from the power draw.

Testing

image

Additional context

@curstwist curstwist added [C++] Changes (can be) made in C++. Previously named `Code` Bionics CBM (Compact Bionic Modules) labels Nov 3, 2019
@ZhilkinSerg ZhilkinSerg merged commit 8414e72 into CleverRaven:master Nov 3, 2019
@Fris0uman Fris0uman deleted the bio_magnet branch November 3, 2019 14:39
Ramza13 pushed a commit to Ramza13/Cataclysm-DDA that referenced this pull request Nov 5, 2019
* gives message when gitting monster using bio_magnet

* slightly clearer description
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bionics CBM (Compact Bionic Modules) [C++] Changes (can be) made in C++. Previously named `Code`
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Weaponizing Electromagnetic Unit CBM issues
3 participants