Proper unvisited member report fix #35079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
esotericist
added
[C++]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Infrastructure "Proper unvisited member report fix"Purpose of change
the config option for unvisited member reports introduced in #35065 can cause a crash on quit due to how things get unloaded at quit time.
also, the use of config options that defaulted off caused the unvisited member reports to not be run in CI, which was apparently a key purpose of that functionality.
Describe the solution
revert #35065
make the unvisited member reports only run when
test_modeis true, which should only be the case when running the test suiteDescribe alternatives you've considered
my original attempt at this was #35073, which worked for the crash error, but did not address the fact this test need to run in CI
Testing
loaded a save game (to confirm the slowdown was gone)
ran tests with this change (to confirm tests still work)
ran tests with an older version of master where the unvisited member reports were unconditional (which verified the time was the same)
ran tests with master as of this writing where unvisited member reports are conditional based on config options (which verified the time was slightly faster)
Additional context
Well, I learned things, even if they ended up not being applicable.