Added debug options for reporting unvisited json members #35065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes CleverRaven#35035 But it is just a hotfix and should be properly refactored later.
ZhilkinSerg
added
Code: Performance
|
compiles fine on Linux with CLANG=1 RUNTESTS=1 LINTJSON=1 |
This was referenced Oct 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: NonePurpose of change
Fixes #35035
Describe the solution
Added two debug options to control reporting of unvisited json members to
debug.log.Testing
Try loading a considerably large savegame with and without options enabled (especially second option).
Additional context
Follow-up after #34735
I consider this a hotfix and it should be properly refactored later.