Bionic UI: power display in kJ, J, mJ #34753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
#34706 has something very similar |
RDru
changed the title
Mine is about bionic UI window. His is about displaying total power in character panel I think (?). |
|
Yep it's the panel. |
Added screenshot. |
ZhilkinSerg
added
[C++]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Interface "Bionic UI: power displayed in kJ, J or mJ"Purpose of change
Power was always displayed in kJ
Describe the solution
Made function that return a string with value and unit.
Named it just "display" for future override for other units.
Describe alternatives you've considered
I was thinking about creating units.ccp
Testing
Loaded a save, it displays correctly.
Additional context
Also changed the description of artificial night generator that I changed in #34456 and forgot about description
