Limit "this task is too simple to train [skill] beyond [number]" messages to once per craft #34632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Interface "Limits "this task is too simple to train" messages to once per craft or batch craft"Purpose of change
Fixes #34077
This makes "this task is too simple to train [skill] beyond [number]" only show once per craft or batch craft.
Describe the solution
I pulled out the section of code that handles the message into a method. This method is called from its former location and at the beginning of crafting. Added a new optional parameter to the practice method to allow suppressing the warning message and used this parameter only from crafting so other skills are unaffected.
Describe alternatives you've considered
I first added an option to allow suppressing this message based on time for all skills but that didn't feel right.
Additional context