Add steel armor clothing mod

[snipercup]

Summary

SUMMARY: Content "Adds steel armor clothing mod"

Purpose of change

Follow up on #34571.

Describe the solution

You can now pad your clothes with steel_armor and a tailors kit.

Describe alternatives you've considered

I used the same stats as leather_padded but i feel like there should be a difference. maybe have leather_padded add warmth?

Additional context

[tenmillimaster]

Should the steel padded armor variants get obsoleted then?

Also I'd call it 'lined', not 'padded'.

[snipercup]

Can you give me an example of a steel padded armor variant?

[ghost]

Can you give me an example of a steel padded armor variant?

Armored leather jacket, armored leather vest, pair of armored fingerless gloves, plated leather armor, pair of armored gauntlets, pair of armored boots.

[Rivet-the-Zombie]

pair of armored gauntlets, pair of armored boots

These two aren't just 'a bit of clothing with added metal' but are rather meant to be armor in their own right - the non-metal bits just serve to keep the metal pieces together.

[snipercup]

I'm scratching my head over the plated leather armor but I think i'll come up with something and hopefully I can extend that to the other items you mentioned.

[kevingranade]

The problem with the clothing modification system is it doesn't have any meaningful limitations on which items can be modified. Steel is particularly problematic due to it's high weight.

I'm not particularly inclined to add more to this system at all, and to have any chance of this being ok, it needs to have a mechanism for limiting what clothes you can apply it to.

[snipercup]

The problem with the clothing modification system is it doesn't have any meaningful limitations on which items can be modified. Steel is particularly problematic due to it's high weight.

I'm not particularly inclined to add more to this system at all, and to have any chance of this being ok, it needs to have a mechanism for limiting what clothes you can apply it to.

Yeah I thought it was a bit strange when I applied steel plating to my socks. I don't feel confident in my C++ skills yet but I did think about looking at the code for repairing. There is a filter applied there somewhere. I'll leave the PR open for 1 day and then close it unless someone is interested in helping develop this idea.

[Davi-DeGanne]

I am willing to take a stab at the C++ legwork, if you come up with a JSON flag/property you want to use to differentiate it.

[snipercup]

I am willing to take a stab at the C++ legwork, if you come up with a JSON flag/property you want to use to differentiate it.

Thanks for wanting to help. The first thing that comes up is a whitelist flag that can be applied to any clothing that you want to be able to be padded. For example when entering an item's flags, you add can_pad_steel, can_pad_leather, can_line_fur

Alternatively you could check an itemgroup and items in that group can be padded

[Davi-DeGanne]

How about using something existing, like material_thickness or STURDY?

[snipercup]

I will look into it.

[snipercup]

I think a pretty good selection is items that have material: leather, flag: sturdy and material_thickness: >3 and only Covers: Legs and/or torso (and arms). I can probably write a query to see what items come up but I'm pretty confident that these items are a good selection to start with. This would also exclude the items LaVeyanFiend mentions except for the plated leather armor. I can think of some options for the plated leather armor but i'll get to that later.

[Davi-DeGanne]

Just thought of a more elegant way of doing it, sort of an extension of one of your ideas: We'll have an optional JSON property valid_items for clothing mods which, if present, restricts the clothing mod such that it can only be applied to the listed items.

@kevingranade Is this an acceptable solution?

[kevingranade]

That's better than the heuristic approach.
Generally you'd flip it around and put it on the clothing, i.e. "valid_mods": [ "steel_insert" ],

[Davi-DeGanne]

What's the justification for doing it that way instead? I kind of prefer my approach, as it doesn't invalidate the existing four clothing mods until someone goes through all the existing armor/clothing and adds valid_mods entries where applicable.

[kevingranade]

Neither one invalidates anything unless you code it to do so. Treat it as a whitelist and everything is fine.

As for the reason, it's far easier to maintain tags on items than it is to maintain centralized lists of items. Similarly it handles new items added by mods more seamlessly.

[snipercup]

@kevingranade Can this PR be merged now that #34705 is merged? I will make another PR that will put this steel clothing mod to use.

[cainiaowu]

mostly lack of maintainers time, you may need to ask directly on discord or it may get missed.

[snipercup]

@kevingranade Could you take another look at this PR?

[kevingranade]

It needs to be marked restricted as discussed, and have at least one article of clothing with it added to the modification whitelist.

[snipercup]

Steel padded clothing mod is now restricted.
I added valid_mods to some clothing items.
Steel padded can now be applied:

Cannot be applied to other clothing:

Please review/merge