Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed "Item duplication on pick up to wield" #34297

Merged

Conversation

ipcyborg
Copy link
Contributor

Summary

SUMMARY: Bugfixes "Item duplication on pick up to wield"

Purpose of change

Fixes #33646

Describe the solution

Adjust picked up item charges (after a successful wield action).

Describe alternatives you've considered

Somehow make 'pick up' transaction atomic, with correct commit and rollback? So it will not require item duplication.

Additional context

Related PR #33422

@ZhilkinSerg ZhilkinSerg added <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` Items / Item Actions / Item Qualities Items and how they work and interact labels Sep 28, 2019
@ZhilkinSerg ZhilkinSerg merged commit 5915b0e into CleverRaven:master Sep 28, 2019
@ipcyborg ipcyborg deleted the fix-33646-pickup-item-duplicate branch September 28, 2019 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` Items / Item Actions / Item Qualities Items and how they work and interact
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Item duplication on pick up to wield
2 participants