Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a methlab basement, new palette for residential basements #28958

Merged
merged 2 commits into from
Mar 31, 2019

Conversation

anothersimulacrum
Copy link
Member

@anothersimulacrum anothersimulacrum commented Mar 24, 2019

Summary

SUMMARY: Content "Adds basement with a hidden methlab"

Purpose of change

The game was previously lacking a methlab basement. This aims to fix it.

Describe the solution

Add a few new itemgroups, a new palette, and a new basement. Two varieties, one with methlab, and one without.

Additional context

I might clean up the methlab item group and some itemgroup stuff in a few later PR, and I plan on adding some more residential basements.
Pictures:
LivepeopleLab
RetrodaysLab
ASCIILab
LivepeopleNoLab
RetrodaysNoLab
LivepeopleNoLab2
RetrodaysNoLab2

@Night-Pryanik
Copy link
Contributor

Hiding enter to meth lab behind a bookcase makes sense, of course, but most players won't find it, ever. They have absolutely no clue that there might be something behind that bookcase. I encounterd the same problem when I designed my autodoc basement. You should add some hint - I don't know, maybe some field, or graffiti, or chems lying on the bookcase.

@Night-Pryanik
Copy link
Contributor

That's a really big basement - it has two bedrooms, two bathrooms, a large dining room, a hall and several utility rooms. It looks like a completely functional home rather than a basement.

@umsretuza
Copy link
Contributor

Initially I thought the screenshots were showcasing the house itself and not the basement. It resembles a surface home/2nd floor quite well. Might want to dial back on the home-like feeling, and more towards an illegal den feeling.

@Photoloss
Copy link
Contributor

That's a really big basement - it has two bedrooms, two bathrooms, a large dining room, a hall and several utility rooms. It looks like a completely functional home rather than a basement.

A rare spawn imitating European styles could make sense unless New England laws prohibit it. However the walls should be made of concrete in that case (bonus points for a red brick house on top!) and this motivation does not line up with the intent of the PR: the chance of a Europhile also being a DIY methhead becomes vanishingly small.

@anothersimulacrum
Copy link
Member Author

Updated OP with pictures.
I removed the second bedroom, bathroom, dining room, and rec room, and added some random crate spawns.
Methlab variant will now have meth spawn on the bookshelves, toxic gas in the air and a body/knife/bleach in the laundry room to encourage investigation.

@mlangsdorf mlangsdorf added [JSON] Changes (can be) made in JSON Map / Mapgen Overmap, Mapgen, Map extras, Map display labels Mar 24, 2019
@DracoGriffin
Copy link
Contributor

Is the toxic gas permanent? That'd be a bit weird.

Also, I thought the previous basement was fine (albeit too large); it's a bit cliche to always assume it wouldn't look clean. It's a bit strange to assume only rednecks or uneducated folk are somehow masterminds of the meth business.

@anothersimulacrum
Copy link
Member Author

anothersimulacrum commented Mar 25, 2019

I could add back in the previous basement with a low weight. The toxic gas isn't permanent, which does bring about the problem that it might fade before you find it, but is better than a constant cloud. The crates are just to imply that it's unfinished, after discussion on the discord.

Accidentally closed this, sorry. That button shouldn't be so close.

@Mecares
Copy link
Contributor

Mecares commented Mar 25, 2019

Maybe add a variant that has the same room layout as the Meth Lab but does contain normal rooms, so that the Player might recognise the Basement layout and thinks something like: That is odd normally there is the storage room in this direction instead of those shelves.

@anothersimulacrum anothersimulacrum changed the title Add a methlab basement, new palette for residential basements [WIP] Add a methlab basement, new palette for residential basements Mar 25, 2019
@ZhilkinSerg ZhilkinSerg removed their assignment Mar 26, 2019
@anothersimulacrum anothersimulacrum changed the title [WIP] Add a methlab basement, new palette for residential basements Add a methlab basement, new palette for residential basements Mar 26, 2019
@anothersimulacrum
Copy link
Member Author

Updated, and added more pictures to the OP. Added a new variant with a room behind where the bookshelves go, and added a chance for a hazmat zombie to spawn outside the room in the meth variant.
Also added chance for normal zombies to spawn in all variants, and locked the door to the laundry room in the meth variant, though it's not in the pictures.

@ZhilkinSerg ZhilkinSerg self-assigned this Mar 27, 2019
@ZhilkinSerg ZhilkinSerg mentioned this pull request Mar 28, 2019
@ZhilkinSerg ZhilkinSerg self-assigned this Mar 31, 2019
@ZhilkinSerg ZhilkinSerg merged commit b7ff9a0 into CleverRaven:master Mar 31, 2019
@ZhilkinSerg ZhilkinSerg removed their assignment Mar 31, 2019
@anothersimulacrum anothersimulacrum deleted the basements branch March 31, 2019 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[JSON] Changes (can be) made in JSON Map / Mapgen Overmap, Mapgen, Map extras, Map display
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants