Chemistry Tools 2: Add basic analytical science tools #27212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZhilkinSerg
added
[JSON]
Co-Authored-By: I-am-Erk <[email protected]>
Place science.json in the items/tools folder to reduce the burden of reading a single large json
Mixed cuvettes and burettes up. It's been a while since I did labwork.
These are for crafting the spectrophotometer.
The linting is annoying me.
ZhilkinSerg
reviewed
Dec 28, 2018
Co-Authored-By: I-am-Erk <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Infrastructure "Adds not-quite implemented basic analytical tools for chemistry."Purpose of change
Using new chemistry qualities (#27206), adds the sub-tools that collectively form a "basic analytical kit" with analysis quality 1.
Describe the solution
After some discussion I think the most important analytical tools for common chemical synthesis are:
I have created sub-tools to represent these tools, and a "kit" tool that includes all of them and has an analysis 1 quality.
Describe alternatives you've considered
Each of these items could have analysis 1 individually, but that winds up with weird things like using a melting point apparatus to determine if your ethanol is pure. Instead, if a recipe only needs a melting point apparatus, you could always include that in the recipe or something.
Additional context
Part of an ongoing effort to add science tools, without putting them all in a single huge PR.
Next up will be recipes to construct and disassemble these tools. Or maybe item groups to get these tools into the game. I don't know yet.