Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DinoModv3: DinoDNA #26525

Merged
merged 47 commits into from
Mar 6, 2020
Merged

DinoModv3: DinoDNA #26525

merged 47 commits into from
Mar 6, 2020

Conversation

LyleSY
Copy link
Contributor

@LyleSY LyleSY commented Nov 4, 2018

SUMMARY: Content "DinoMod:Adds dino eggs, dino egg laying, dino hatchlings, rebalancing weights and volumes, cleanup"

Another step towards #25294 this creates dino eggs to become an ingredient for raptor mutagen and potentially become a project to go into the main game, plus adjusts DinoMod weights to be more realistic per #25631 . This pull includes and updates content from #26443 in its entirety

Copies bird reproduction system, creates dino eggs and hatchlings, adds dino eggs to forage group, fixes weights to match wikipedia, removes unused item chance and luminance lines, rebalances compies to attack prey and attack the player less, removes huge dinos from the sewer, removes non-dinos, makes Deinonychus a pack hunter in caves, spellchecks the 'deinonychus' faction, removes broken mapgen files, changes raptor mutagen recipe to be slightly easier and use dino eggs, velociraptor eggs, utahraptor eggs, and deinonychus eggs.

LyleSY and others added 14 commits September 17, 2017 12:13
Adds compies, gallimimus, titanis, spinosarus, ankylosaurus, and eoraptor to spawn in forests. Includes domestic group as prep to add dinos there (not yet implemented). Restores vanilla snippets to game in addition to DinoMod content. Adds new dino content to lab notes. Overall, you see more dinos and more written content.
Removed duplicate notes and snippets to reduce file size.
Responses to feedback, more dinos still, and some corrections to put dinos in more realistic locations.

Rebalances Compsognathus to more realistically stand up to sewer rats, adds more dinosaurs in the forests and pulls Compsognathus since that was a coastal critter, removes GROUP_DOMESTIC for now, adds more swamp dinos, adds pack behavior for Deinonychus, adds sewer gators to copy main, pulls Eoraptor from "safe" group. Removes Smoky again.
Added egg laying to dinos, created hatchlings, allowed dino eggs to be foraged. Rebalanced compies again to be less menacing to player and more menacing to other monsters. Compies and hatchlings can be tamed. Rebalanced weights and volumes based on google searches, mainly wikipedia. Assuming dino specific gravity of one, which is close enough.  Removed item chance and luminance lines since dinos don't use them. Added dino dung which looks a lot like bird droppings. Rebalanced cave and sewer groups to remove huge dinos from sewers, non-dinos from caves, and make Deinonychus pack hunters in caves, spellcheck deinonychus faction.
forage, egg, and monstergroups_egg with new egg_dino info
Removing unneeded lines
@ZhilkinSerg ZhilkinSerg added [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding Spawn Creatures, items, vehicles, locations appearing on map Monsters Monsters both friendly and unfriendly. Items / Item Actions / Item Qualities Items and how they work and interact labels Nov 5, 2018
Titanis and Dimorphodon are headed to Crazy Cataclysm to allow focus on dino development in DinoMod.
Cannot get the one DinoMod location to spawn naturally from mapgen. Unable to troubleshoot. Testing on the one location shows it isn't very interesting or fun. Removing. Mapgen has enough trouble without DinoMod mucking it up with a universal regional overlay.
Allows scavenged dino eggs, velociraptor eggs, utahraptor eggs, and deinonychus eggs, reduces difficulty and time and scarcity of other materials to match lizard mutagen.
@LyleSY
Copy link
Contributor Author

LyleSY commented Dec 18, 2018

I don't have authority to merge this. Can someone with access make that happen?

@cainiaowu
Copy link
Contributor

https://travis-ci.org/CleverRaven/Cataclysm-DDA/jobs/453076321

The build is failed with Formatted data/mods/DinoMod/egg.json

Your files need to go though the web linter.

Removed all special_freq code and most special_attack code
@LyleSY
Copy link
Contributor Author

LyleSY commented Jan 30, 2020

Removed all special_freq and most special_attack code from dinosaur.json since they were deprecated in like 2014.

You can ride a dinosaur now.
@damien
Copy link
Contributor

damien commented Jan 31, 2020

Question: Does the 0.E Content Freeze tag mean that we still have a chance of getting this into that release? @LyleSY has done a lot of work here expanding and modernizing the mod and I'd love to see it on Stable if we can swing it.

Let us know if there's anything we can do to make that happen!

@KorGgenT
Copy link
Member

no unfortunately content freeze means it just missed the boat.

@damien
Copy link
Contributor

damien commented Jan 31, 2020

Rats! Well, all aboard the 0.F hype train!

Noticed that an update has killed all dinosaur spawns. Added    " "is_animal": true, " to all the groups. Also some cleanup to move the newly dangerous compies off the safe lists and on to a dangerous dino list. Linted just in case.
@LyleSY
Copy link
Contributor Author

LyleSY commented Feb 2, 2020

Playtesting revealed pretty quickly that all dino spawns were broken without debugging them in. Fixed that and tested working.

@ZhilkinSerg
Copy link
Contributor

Question: Does the 0.E Content Freeze tag mean that we still have a chance of getting this into that release? @LyleSY has done a lot of work here expanding and modernizing the mod and I'd love to see it on Stable if we can swing it.

Let us know if there's anything we can do to make that happen!

Don't worry - post-0.E would be a quick merge train.

@ZhilkinSerg ZhilkinSerg changed the base branch from master to dev March 6, 2020 10:08
@ZhilkinSerg ZhilkinSerg merged commit 162b8d5 into CleverRaven:dev Mar 6, 2020
@ZhilkinSerg ZhilkinSerg mentioned this pull request Mar 6, 2020
13 tasks
ZhilkinSerg pushed a commit that referenced this pull request Mar 7, 2020
ZhilkinSerg pushed a commit that referenced this pull request Mar 10, 2020
ZhilkinSerg pushed a commit that referenced this pull request Mar 15, 2020
ZhilkinSerg pushed a commit that referenced this pull request Mar 15, 2020
ZhilkinSerg pushed a commit that referenced this pull request Mar 16, 2020
ZhilkinSerg pushed a commit that referenced this pull request Mar 17, 2020
ZhilkinSerg pushed a commit that referenced this pull request Mar 17, 2020
ZhilkinSerg pushed a commit that referenced this pull request Mar 18, 2020
ZhilkinSerg pushed a commit that referenced this pull request Mar 29, 2020
ZhilkinSerg pushed a commit that referenced this pull request Apr 1, 2020
ZhilkinSerg pushed a commit that referenced this pull request Apr 2, 2020
ZhilkinSerg pushed a commit that referenced this pull request Apr 2, 2020
@LyleSY LyleSY deleted the DinoDNA branch April 30, 2020 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Items / Item Actions / Item Qualities Items and how they work and interact [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding Monsters Monsters both friendly and unfriendly. Spawn Creatures, items, vehicles, locations appearing on map
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants