Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sewing related items voids charges reloaded and unloaded from them #40246

Closed
pepesito1122 opened this issue May 6, 2020 · 2 comments
Closed
Labels
<Bug> This needs to be fixed Items: Magazines Ammo holding items and objects. (S3 - Duplicate) Bug that is duplicate of another one

Comments

@pepesito1122
Copy link
Contributor

Describe the bug

Items I've used with the sewing quality has a nasty bug that completely removes thread put into them for repairing items. And with the Sewing Kits I spawn in with their stock 50 thread, it gives me a 'none' item, effectively voiding the charges pulled out of them.

Steps To Reproduce

  1. Spawn in items with sewing quality (Wooden Needle, Sewing Kit, Tailoring Kit, etc,) and thread.

[Reloading charges]
2a. Reload the sewing tool with thread.
3a. See that the value is left unchanged, totally destroys your thread.

[Unloading charges]
2b. Attempt unload the stock charges of a Sewing Kit/Tailor's Kit.
3b. Sewing tool does not return thread, instead gives a 'None' item that is absolutely nothing, voiding charges again.

Expected behavior

I'm not sure. It probably has something to do with nested inventory, but that's the first thing that comes to mind.

Versions and configuration

  • OS: Windows 10
  • Game Version: 0.E-1811-gafd8407
  • Graphics Version: Tiles
  • Ingame Language: System Language
  • Mods Loaded: ["dda", "no_npc_food"]

Additional context

This is the log the game gave me with I tried to unload thread from a Tailor's Kit.

DEBUG : cannot determine reload cost as none is neither ammo or magazine

FUNCTION : int player::item_reload_cost(const item&, const item&, int) const
FILE : src/player.cpp
LINE : 2894

@KorGgenT KorGgenT added <Bug> This needs to be fixed Items: Magazines Ammo holding items and objects. labels May 6, 2020
@Reango
Copy link

Reango commented May 6, 2020

I've had the same issue in its entirety.

@ZhilkinSerg ZhilkinSerg added the (S3 - Duplicate) Bug that is duplicate of another one label May 7, 2020
@ZhilkinSerg
Copy link
Contributor

Duplicate of #40125

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bug> This needs to be fixed Items: Magazines Ammo holding items and objects. (S3 - Duplicate) Bug that is duplicate of another one
Projects
None yet
Development

No branches or pull requests

4 participants