Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot reload the sewing kit with thread. Thread is gone, no reloading. #40125

Closed
romanpogosov-usa opened this issue May 4, 2020 · 8 comments · Fixed by #40399
Closed

Cannot reload the sewing kit with thread. Thread is gone, no reloading. #40125

romanpogosov-usa opened this issue May 4, 2020 · 8 comments · Fixed by #40399
Assignees
Labels
<Bug> This needs to be fixed Inventory / AIM / Zones Inventory, Advanced Inventory Management or Zones Items: Containers Things that hold other things (S2 - Confirmed) Bug that's been confirmed to exist

Comments

@romanpogosov-usa
Copy link

Cannot reload the sewing kit with thread. Thread is gone, no reloading.

DEBUG : tried to put an item in a container that cannot contain it

FUNCTION : int item::fill_with(const itype&, int)
FILE : src/item.cpp
LINE : 8146

Steps To Reproduce

  1. Try to reload sewing kit with thread.
  2. After reload - sewing kit is empty, thread is gone.

Expected behavior

Reload should reload thread in a sewing kit.

Versions and configuration

  • OS: Windows
    • OS Version: 10.0 1903
  • Game Version: 0.E-1713-gd15c896 [64-bit]
  • Graphics Version: Tiles
  • Game Language: System language []
  • Mods loaded: [
    Dark Days Ahead [dda],
    Disable NPC Needs [no_npc_food],
    Alternative Map Key [alt_map_key],
    Mining Mod [Mining_Mod],
    More Survivor Stuff [more_survivor_stuff],
    More City Locations [cityside],
    SpeedyDex [speedydex],
    Stats Through Skills [StatsThroughSkills]
    ]

Additional context

DEBUG : tried to put an item in a container that cannot contain it

FUNCTION : int item::fill_with(const itype&, int)
FILE : src/item.cpp
LINE : 8146

@ZhilkinSerg ZhilkinSerg added (S1 - Need confirmation) Report waiting on confirmation of reproducibility Inventory / AIM / Zones Inventory, Advanced Inventory Management or Zones Items: Containers Things that hold other things labels May 4, 2020
@Kouwed
Copy link

Kouwed commented May 4, 2020

Same happened to me with wooden needle at latest update. Did not matter if i had wielded the needle or if it was in backpack

@Ivan-Shestakov
Copy link
Contributor

Still happens on latest build. Neither wooden needle nor hobo stove can be loaded with charges. The charges (thread and tinder respectively) disappear.

@Stephen2
Copy link
Contributor

Stephen2 commented May 12, 2020

Still happening in latest at hash 702b0b4 😭

@Ivan-Shestakov
Copy link
Contributor

Yep, happens for all thread related tools - bone needle, wood needle, sewing kit, tailor's kit.
Makes it impossible to fix-up clothing and backpacks :(

@Emotions211
Copy link
Contributor

Also happens to repair kits. Misc. Repair kits will consume up to 200 duct-tape per try but never load it. Practically removes the ability to ever repair many items as repair kits don't spawn with charges and sewing/tailor kits on spawn with 50.

@kwl01skz
Copy link
Contributor

the same bug on oil lamps #40652

I found the suspicious code at #39406
@ZhilkinSerg

@Stephen2
Copy link
Contributor

Legends!!!

@romanpogosov-usa
Copy link
Author

Yay, can play now with the new code. thanks!!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bug> This needs to be fixed Inventory / AIM / Zones Inventory, Advanced Inventory Management or Zones Items: Containers Things that hold other things (S2 - Confirmed) Bug that's been confirmed to exist
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants