Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Application flow fixes #1578

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Application flow fixes #1578

wants to merge 9 commits into from

Conversation

vincit-matu
Copy link
Contributor

@vincit-matu vincit-matu commented Dec 15, 2024

🛠️ Changelog

  • Addresses the issues listed on the application flow ticket (TILA-3560), apart from ones to do with validating that the specific timespans correspond to the given amount and duration in the application
  • Fixes page2 of the application flow in respect to the application sections, and selected reservation units

🧪 Test plan

  • Check out the application flow, comparing it to the design in figma.
  • Make an application with more than one sections and note, that you can now enter the primary/secondary timeslots and the form should all-in-all work as expected when filling in details for more than one section in one application. Using sections with different selections of spaces makes this easier to see at a glance.

🎫 Tickets

  • TILA-3560

@vincit-matu vincit-matu force-pushed the application-flow-fixes branch from e923156 to 03ba9c6 Compare December 15, 2024 01:26
@vincit-matu vincit-matu marked this pull request as ready for review December 18, 2024 12:48
@vincit-matu vincit-matu force-pushed the application-flow-fixes branch from 2c56cd3 to 571d445 Compare December 18, 2024 13:06
Copy link
Contributor

@joonatank joonatank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the stepper comparison is questionable

apps/ui/components/application/ApplicationPage.tsx Outdated Show resolved Hide resolved
apps/ui/components/application/ApplicationPage.tsx Outdated Show resolved Hide resolved
apps/ui/components/application/ApplicationPage.tsx Outdated Show resolved Hide resolved
apps/ui/components/application/reservation-unit-card.tsx Outdated Show resolved Hide resolved
apps/ui/components/application/reservation-unit-card.tsx Outdated Show resolved Hide resolved
apps/ui/components/application/reservation-unit-card.tsx Outdated Show resolved Hide resolved
@vincit-matu vincit-matu force-pushed the application-flow-fixes branch from 04ab755 to 0666320 Compare January 4, 2025 16:20
@vincit-matu vincit-matu requested a review from joonatank January 4, 2025 16:45
@vincit-matu
Copy link
Contributor Author

vincit-matu commented Jan 4, 2025

Addressed the issues raised by @joonatank, ready for re-review

p.s. no idea why the admin test are failing.. this branch doesn't change anything on the admin side

Copy link
Contributor

@joonatank joonatank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CSS is super weird and verbose for the Card. the amount of !important seems that something is wrong. Either use HDS CSS vars or don't use HDS Buttons as base.

If special buttons start requiring 50 lines of CSS maybe we should talk to the Designer and make them into components.

apps/ui/components/application/reservation-unit-card.tsx Outdated Show resolved Hide resolved
apps/ui/components/application/reservation-unit-card.tsx Outdated Show resolved Hide resolved
apps/ui/components/application/reservation-unit-card.tsx Outdated Show resolved Hide resolved
apps/ui/components/application/reservation-unit-card.tsx Outdated Show resolved Hide resolved
apps/ui/components/application/reservation-unit-card.tsx Outdated Show resolved Hide resolved
apps/ui/components/application/reservation-unit-card.tsx Outdated Show resolved Hide resolved
apps/ui/components/application/reservation-unit-card.tsx Outdated Show resolved Hide resolved
apps/ui/components/application/reservation-unit-card.tsx Outdated Show resolved Hide resolved
apps/ui/components/application/reservation-unit-card.tsx Outdated Show resolved Hide resolved
apps/ui/components/application/reservation-unit-card.tsx Outdated Show resolved Hide resolved
@vincit-matu vincit-matu force-pushed the application-flow-fixes branch from d030a66 to 4d5cf81 Compare January 12, 2025 19:44
@vincit-matu vincit-matu requested a review from joonatank January 12, 2025 19:47
@vincit-matu vincit-matu force-pushed the application-flow-fixes branch 2 times, most recently from 310db20 to 1b9b28d Compare January 13, 2025 11:43
@vincit-matu vincit-matu force-pushed the application-flow-fixes branch from 1b9b28d to efe5ba9 Compare January 13, 2025 11:58
- uses css-variables instead of !important overrides
- moves stuff around accordingly
- refactors file names to PascalCase for uniformity
@vincit-matu vincit-matu force-pushed the application-flow-fixes branch from efe5ba9 to 17d0f29 Compare January 13, 2025 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants