-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Application flow fixes #1578
base: main
Are you sure you want to change the base?
Application flow fixes #1578
Conversation
e923156
to
03ba9c6
Compare
2c56cd3
to
571d445
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the stepper comparison is questionable
04ab755
to
0666320
Compare
Addressed the issues raised by @joonatank, ready for re-review p.s. no idea why the admin test are failing.. this branch doesn't change anything on the admin side |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CSS is super weird and verbose for the Card. the amount of !important
seems that something is wrong. Either use HDS CSS vars or don't use HDS Buttons as base.
If special buttons start requiring 50 lines of CSS maybe we should talk to the Designer and make them into components.
- removes Stepper.tsx as it's no longer in use
- the different sections now show proper timetables
- also fixes reservation-unit-card aria-hidden
d030a66
to
4d5cf81
Compare
310db20
to
1b9b28d
Compare
1b9b28d
to
efe5ba9
Compare
- uses css-variables instead of !important overrides - moves stuff around accordingly - refactors file names to PascalCase for uniformity
efe5ba9
to
17d0f29
Compare
🛠️ Changelog
🧪 Test plan
🎫 Tickets