Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UHF-9755 Configuration replacement #393

Merged
merged 3 commits into from
Mar 25, 2024
Merged

UHF-9755 Configuration replacement #393

merged 3 commits into from
Mar 25, 2024

Conversation

khalima
Copy link
Contributor

@khalima khalima commented Mar 20, 2024 •
edited by hyrsky
Loading

UHF-9755

What was done

  • Added paatokset_config module and enabled it. Converted paatokset specific customisations to use the rewritten configurations
  • Updated configurations based on replaced custom configurations

How to install

  • Make sure your instance is up and running on correct branch.
    • git checkout UHF-9755
    • make fresh
  • Run make drush-cr

How to test

  • Force an update for all of the platform config modules by retrieving the test branch from platform config and running the update command for it in shell.
    • composer require drupal/helfi_platform_config:dev-UHF-X_test_massive_update
    • in shell run: drush eval "module_load_include('install', 'hdbt_admin_tools', 'hdbt_admin_tools'); hdbt_admin_tools_test_massive_update();"; drush cex -y
  • Check that the changed configurations seem sensible. I.e. None of the updates have removed the customised metatag configurations.
  • Check that code follows our standards

Other PRs

hyrsky
hyrsky approved these changes Mar 21, 2024
View reviewed changes
Copy link
Contributor

@hyrsky hyrsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@khalima khalima merged commit dd541fa into dev Mar 25, 2024
1 check passed
@khalima khalima deleted the UHF-9755 branch March 25, 2024 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hyrsky hyrsky hyrsky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@khalima @hyrsky