Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-9755 Configuration replacement #790

Merged
merged 8 commits into from
Mar 21, 2024
Merged

UHF-9755 Configuration replacement #790

merged 8 commits into from
Mar 21, 2024

Conversation

khalima
Copy link
Contributor

@khalima khalima commented Mar 15, 2024

UHF-9755

What was done

  • Added helfi_sote_config module and enabled it. Converted helfi_sote specific customizations to use the rewritten configurations
  • Updated configurations based on replaced custom configurations

How to install

  • Make sure your instance is up and running on correct branch.
    • git checkout UHF-9755
    • make fresh
  • Run make drush-cr

How to test

  • Force an update for all of the platform config modules by retrieving the test branch from platform config and running the update command for it in shell.
    • composer require drupal/helfi_platform_config:dev-UHF-X_test_massive_update
    • in shell run: drush eval "module_load_include('install', 'hdbt_admin_tools', 'hdbt_admin_tools'); hdbt_admin_tools_test_massive_update();"; drush cex -y
  • Check that the changed configurations seem sensible. I.e. None of the updates have removed the customised configurations.
  • Check that code follows our standards

Other PRs

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

@teroelonen teroelonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works well 🦖

@khalima khalima changed the base branch from dev to update-configuration March 21, 2024 07:56
@khalima khalima merged commit 4213e9f into update-configuration Mar 21, 2024
2 checks passed
@khalima khalima deleted the UHF-9755 branch March 21, 2024 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants