Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-9712 og image size #169

Closed
wants to merge 4 commits into from
Closed

UHF-9712 og image size #169

wants to merge 4 commits into from

Conversation

hyrsky
Copy link
Contributor

@hyrsky hyrsky commented Mar 6, 2024

UHF-9712

What was done

  • Run trp unit og image through image style.

How to install

  • Make sure your instance is up and running on latest dev branch.
    • git pull origin dev
    • make fresh
  • Update the Helfi Platform config & TPR
    • composer require drupal/helfi_tpr:dev-UHF-9712-og-image-size
    • composer require drupal/helfi_platform_config:dev-UHF-9712-og-image-size
  • Run make drush-updb drush-cr

How to test

  • Check that this feature works
  • Check that code follows our standards

Other PRs

@hyrsky hyrsky force-pushed the UHF-9712-og-image-size branch from 505e837 to 4cbcfc9 Compare March 6, 2024 07:06
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 50.00000% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 81.52%. Comparing base (44f69ad) to head (10bc690).

❗ Current head 10bc690 differs from pull request most recent head 4cbcfc9. Consider uploading reports for the commit 4cbcfc9 to get more accurate results

Files Patch % Lines
src/Entity/Unit.php 50.00% 5 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #169      +/-   ##
============================================
- Coverage     81.65%   81.52%   -0.13%     
- Complexity      361      364       +3     
============================================
  Files            50       50              
  Lines          2883     2891       +8     
============================================
+ Hits           2354     2357       +3     
- Misses          529      534       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hyrsky hyrsky force-pushed the UHF-9712-og-image-size branch from 217f86e to f3d678b Compare March 12, 2024 07:04
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@hyrsky hyrsky closed this Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants