Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-9712: og image fixes #705

Merged
merged 10 commits into from
Mar 18, 2024
Merged

UHF-9712: og image fixes #705

merged 10 commits into from
Mar 18, 2024

Conversation

hyrsky
Copy link
Contributor

@hyrsky hyrsky commented Mar 6, 2024

@hyrsky hyrsky force-pushed the UHF-9712-og-image-size branch 4 times, most recently from 619434b to 811ad07 Compare March 11, 2024 09:27
@hyrsky hyrsky force-pushed the UHF-9712-og-image-size branch 2 times, most recently from 9634b64 to ae5f6d5 Compare March 12, 2024 07:06
src/Token/NodeImageBuilder.php Outdated Show resolved Hide resolved
@hyrsky hyrsky force-pushed the UHF-9712-og-image-size branch from b5218e0 to 26ac9a6 Compare March 12, 2024 08:29
src/Token/DefaultImageBuilder.php Outdated Show resolved Hide resolved
src/Token/OGImageManager.php Outdated Show resolved Hide resolved
src/Token/OGImageManager.php Outdated Show resolved Hide resolved
src/Token/DefaultImageBuilder.php Outdated Show resolved Hide resolved
modules/helfi_tpr_config/src/Token/TprImageBuilder.php Outdated Show resolved Hide resolved
modules/hdbt_admin_tools/hdbt_admin_tools.tokens.inc Outdated Show resolved Hide resolved
@hyrsky hyrsky force-pushed the UHF-9712-og-image-size branch from 1ee7cc9 to a6eb3fd Compare March 12, 2024 09:17
@codecov-commenter
Copy link

codecov-commenter commented Mar 12, 2024

Codecov Report

Attention: Patch coverage is 57.57576% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 14.51%. Comparing base (9d7def6) to head (61c1a20).
Report is 3 commits behind head on main.

❗ Current head 61c1a20 differs from pull request most recent head 3553d1a. Consider uploading reports for the commit 3553d1a to get more accurate results

Files Patch % Lines
src/Token/DefaultImageBuilder.php 0.00% 11 Missing ⚠️
src/Token/OGImageManager.php 86.36% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #705      +/-   ##
============================================
+ Coverage     13.01%   14.51%   +1.50%     
- Complexity      242      256      +14     
============================================
  Files            28       30       +2     
  Lines           945      978      +33     
============================================
+ Hits            123      142      +19     
- Misses          822      836      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hyrsky hyrsky force-pushed the UHF-9712-og-image-size branch 2 times, most recently from 73c4b53 to d04e34d Compare March 14, 2024 06:38
@hyrsky hyrsky force-pushed the UHF-9712-og-image-size branch from d04e34d to 003d1b4 Compare March 14, 2024 06:49
@hyrsky hyrsky force-pushed the UHF-9712-og-image-size branch 3 times, most recently from 759400f to 500217e Compare March 15, 2024 12:38
@hyrsky hyrsky force-pushed the UHF-9712-og-image-size branch from 500217e to b587246 Compare March 15, 2024 13:07
modules/helfi_tpr_config/src/Entity/Unit.php Show resolved Hide resolved
src/Token/OGImageBuilderInterface.php Show resolved Hide resolved
src/Token/OGImageManager.php Show resolved Hide resolved

declare(strict_types=1);

namespace Drupal\Tests\helfi_platform_config\Functional;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be moved to helfi_tpr_config module

Copy link

Quality Gate Passed Quality Gate passed

Issues
4 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants