Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UHF-7298 Remove infinite scroll #134

Merged
merged 3 commits into from
Feb 9, 2023
Merged

UHF-7298 Remove infinite scroll #134

merged 3 commits into from
Feb 9, 2023

Conversation

teroelonen
Copy link
Contributor

@teroelonen teroelonen commented Feb 7, 2023 •
edited
Loading

UHF-7298

What was done

  • Removed references to views_infinite_scroll from the module.

How to install

How to test

Other PRs

@codecov-commenter
Copy link

codecov-commenter commented Feb 7, 2023 •
edited
Loading

Codecov Report

Merging #134 (bc99d29) into main (b5c276d) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              main    #134   +/-   ##
=======================================
  Coverage     0.00%   0.00%           
  Complexity       1       1           
=======================================
  Files            1       1           
  Lines            2       2           
=======================================
  Misses           2       2

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

This was referenced Feb 7, 2023
Merged
Merged
@teroelonen teroelonen marked this pull request as ready for review February 9, 2023 11:49
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

khalima
khalima approved these changes Feb 9, 2023
View reviewed changes
Copy link
Contributor

@khalima khalima left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go! 🚀
Remember to add the notice of future removal of views infinite scroll dependency!

@teroelonen teroelonen merged commit 922bdb0 into main Feb 9, 2023
@teroelonen teroelonen deleted the UHF-7298_remove_infinite_scroll branch February 9, 2023 13:53
This was referenced Feb 9, 2023
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khalima khalima khalima approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@teroelonen @codecov-commenter @khalima