UHF-7298 Remove infinite scroll

[teroelonen]

UHF-7298

What was done

• Removes the infinity scroll functionality from unit search, service list, unit services and service units views and replaces it with full pager implementation.

How to install

• Make sure your instance is up and running on latest dev branch.
  • git pull origin dev
  • make fresh
  • make drush-cim && make drush-uli
• Update the helfi_platform_config, hdbt and helfi_tpr modules to this branch
  • composer require drupal/helfi_platform_config:dev-UHF-7298_remove_infinite_scroll && composer require drupal/helfi_tpr:dev-UHF-7298_remove_infinite_scroll && composer require drupal/hdbt:dev-UHF-7298_remove_infinite_scroll
• Run make drush-cr
• Run make drush-updb drush-cr

How to test

• After the updates have successfully been run we need to make sure views that have had views_infinity_scroll as pager have been changed to use full pager. You can go and check the views from the views UI interface and make sure that the pager has been changed to full pager. The views in question are:
  • /admin/structure/views/view/service_list
  • /admin/structure/views/view/unit_search
  • /admin/structure/views/view/unit_services
  • /admin/structure/views/view/service_units
• Now we still need to make sure that the views are not broken on the theme side either so you need to check each view on the site. Service list and Unit search are paragraphs that you can add to landing page content. The other two are views that are visible on the unit page or service page.
• First go to publish some units /admin/content/integrations/tpr-unit that are similar such as libraries. Publish a lot of them like 10.
• Now on one of the units (Keskustakirjasto Oodi is a good example) go to the edit page and you can see there a list of links under the title "Services". Click each of them to a new tab and publish all of them.
• Now if you visit the Keskustakirjasto Oodi unit page you can see a list of services on the bottom of the page and the block should have full pager.
• Click on one of the services like "Kirjastopalvelut" and you should see on the service page list of units on the bottom of the page that offer that service. The pager should be full pager.
• Now go to create a landing page and add a unit search and service list paragraph and add plenty of units and services to them to enable the pager and save the node. Check that both of the paragraphs work correctly.
• Extra: This should be tested on a new site install as well. So using the composer create-project City-of-Helsinki/drupal-helfi-platform:dev-UHF-7219 test --no-interaction --repository https://repository.drupal.hel.ninja/ and make new and checking that the new installation is run successfully and that you can enable the helfi_tpr without problems and that the new views will have full pager. This could be also reviewed from the code but testing it is always better :)
• Check that code follows our standards

Other PRs

• UHF-7298 Remove infinite scroll #433
• UHF-7298 Remove infinite scroll drupal-hdbt#542
• UHF-7298 Remove infinite scroll drupal-module-helfi-tpr#134

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
2 Code Smells

No Coverage information
0.0% Duplication

[khalima]

Works nicely. 🚀