-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New TPR Service listing component with search #128
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* added name_synonyms field to migration * added name_synonyms field to migration minor fixes * made name_synonyms field readonly and of type string_long * updated id of hook_update * mapped fields to be migrated * Added test for name_synonim migration * update hook to use MigrateIdMapInterface::STATUS_NEEDS_UPDATE Co-authored-by: Dragos Dumitrescu <[email protected]>
… for handle ids or service_ids * migrated service_id field and created argument for view * added service_id assertion to test * coding standards * Fix ServiceIdArgument if no ids are provided * fix for ServiceMigrationTest Co-authored-by: ovidiu <[email protected]>
* created field formatter for errand services * added unique channels * added translated tags * created migrate process for empty array + created has unit field * modified the formatter for the errand service * added the tags into list items theme * added cache * fixed pr comment * removed unused var key * added hasunit to tests + fixes on formatter Co-authored-by: Arsene Claudiu Ion <[email protected]>
* added show channel types setting * add textfield to labels * removed unused var * fixed cachable dependency Co-authored-by: Arsene Claudiu Ion <[email protected]>
* added formatter schema * changed label type to label Co-authored-by: Arsene Claudiu Ion <[email protected]>
* created test for custom view argument * added more assertions to argument test
This was referenced Nov 25, 2022
tuutti
requested changes
Nov 29, 2022
Codecov Report
@@ Coverage Diff @@
## main #128 +/- ##
=======================================
Coverage 0.00% 0.00%
Complexity 1 1
=======================================
Files 1 1
Lines 2 2
=======================================
Misses 2 2 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
tuutti
reviewed
Dec 5, 2022
Kudos, SonarCloud Quality Gate passed! |
tuutti
approved these changes
Dec 5, 2022
This was referenced Dec 13, 2022
This was referenced Dec 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More details at
PLAENH-185
UHF-7656