Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New TPR Service listing component with search #128

Merged
merged 18 commits into from
Dec 5, 2022

Conversation

dragos-dumi-ibm
Copy link
Contributor

More details at
PLAENH-185
UHF-7656

oviag and others added 8 commits November 1, 2022 17:15
* added name_synonyms field to migration

* added name_synonyms field to migration minor fixes

* made name_synonyms field readonly and of type string_long

* updated id of hook_update

* mapped fields to be migrated

* Added test for name_synonim migration

* update hook to use MigrateIdMapInterface::STATUS_NEEDS_UPDATE

Co-authored-by: Dragos Dumitrescu <[email protected]>
… for handle ids or service_ids

* migrated service_id field and created argument for view

* added service_id assertion to test

* coding standards

* Fix ServiceIdArgument if no ids are provided

* fix for ServiceMigrationTest

Co-authored-by: ovidiu <[email protected]>
* created field formatter for errand services

* added unique channels

* added translated tags

* created migrate process for empty array + created has unit field

* modified the formatter for the errand service

* added the tags into list items theme

* added cache

* fixed pr comment

* removed unused var key

* added hasunit to tests + fixes on formatter

Co-authored-by: Arsene Claudiu Ion <[email protected]>
* added show channel types setting

* add textfield to labels

* removed unused var

* fixed cachable dependency

Co-authored-by: Arsene Claudiu Ion <[email protected]>
* added formatter schema

* changed label type to label

Co-authored-by: Arsene Claudiu Ion <[email protected]>
* created test for custom view argument

* added more assertions to argument test
tests/src/Kernel/ServiceIdArgumentTest.php Outdated Show resolved Hide resolved
tests/src/Kernel/ServiceIdArgumentTest.php Show resolved Hide resolved
tests/modules/helfi_tpr_test/helfi_tpr_test.info.yml Outdated Show resolved Hide resolved
src/Entity/Service.php Show resolved Hide resolved
helfi_tpr.module Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Nov 29, 2022

Codecov Report

Merging #128 (33f2034) into main (df201f0) will not change coverage.
The diff coverage is n/a.

❗ Current head 33f2034 differs from pull request most recent head c05d1c2. Consider uploading reports for the commit c05d1c2 to get more accurate results

@@           Coverage Diff           @@
##              main    #128   +/-   ##
=======================================
  Coverage     0.00%   0.00%           
  Complexity       1       1           
=======================================
  Files            1       1           
  Lines            2       2           
=======================================
  Misses           2       2           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 5, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants