-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New TPR service list component with search #407
Conversation
* added service_list_search paragraph type and configured fields * enabled service list paragraph on content region in landing page * added translations for new paragraph fields labels * changed comment in config install Co-authored-by: ovidiu <[email protected]>
* added configuration files for view mode teaser search result * added view service_list to config install * removed uuids from some config isntall + fix enable teaser search result + install views new block * Several updates on config for service list search * updated widget for errand service Co-authored-by: ovidiu <[email protected]> Co-authored-by: Dragos Dumitrescu <[email protected]> Co-authored-by: Arsene Claudiu Ion <[email protected]>
…#5) * added placeholder and title with translations for service list search * reverted some changes on views list defau;t * Fix views search list translations update * fix service errand service formatter in search list Co-authored-by: ovidiu <[email protected]>
* updated config * added settings with label Co-authored-by: Arsene Claudiu Ion <[email protected]>
* add formatter translations for formatter * added translated config to updatehook 30 * fixed translation install Co-authored-by: Arsene Claudiu Ion <[email protected]>
@tuutti |
Ah, makes sense. Seems to work now |
…ing uncachable dynamic cache
Codewise this looks good and is working as described. We're asking for feedback from the UX team and Aleksi about how the paragraph works on the editor side (might need some additional help texts and a better widget for the service grouping IDs). I'll comment here as soon as possible if something needs to be fixed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you edit a service with the "Override: name" field, the title is correctly changed in the search results, but it's not included in the search. If you try searching with the overridden name, you can't find the service.
change service id field label and added help text and translations'
@juho-lehmonen thanks for the review. We've included also the override title in the search
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, thanks for the fixes! This can be merged after the conflicts have been resolved.
89a8cb5
to
468754e
Compare
Kudos, SonarCloud Quality Gate passed! |
@juho-lehmonen the conflicts have been fixed. |
Great, I'll merge this. |
PLAENH-185
UHF-7656
New TPR service list component with search
What was done
More details at
https://helsinkisolutionoffice.atlassian.net/browse/PLAENH-185
How to install
make drush-updb drush-cr
PARTIAL_MIGRATE=1 drush migrate:import tpr_service --no-progress
How to test
Add to a page that has paragraphs the new component "Service List Search"
Configure the component with using service_id and/or specific services
Other PRs