Skip AssetHttpMiddleware processing for JSON:API requests, never redirect POST requests

src/EventSubscriber/RedirectResponseSubscriber.php

@@ -75,9 +75,11 @@ private function buildRedirectUrl(string $url) : string {
   public function onResponse(ResponseEvent $event) : void {
     if (
       !$this->validProxyDomains ||
-      !$this->proxyManager->isConfigured(ProxyManagerInterface::DEFAULT_PROXY_DOMAIN)
+      !$this->proxyManager->isConfigured(ProxyManagerInterface::DEFAULT_PROXY_DOMAIN) ||
+      !$event->getRequest()->isMethod('GET')
     ) {
       // Nothing to do if default proxy domain is not defined.
+      // Only redirect on GET requests as well.
       return;
     }
     $response = $event->getResponse();

src/HttpMiddleware/AssetHttpMiddleware.php

@@ -77,7 +77,11 @@ private function isJsonResponse(Response $response) : bool {
       return TRUE;
     }
 
-    return $response->headers->get('content-type') === 'application/json';
+    $jsonTypes = [
+      'application/json',
+      'application/vnd.api+json',
+    ];
+    return in_array($response->headers->get('content-type'), $jsonTypes);
   }
 
   /**
@@ -112,10 +116,12 @@ public function handle(
     if ($this->isXmlResponse($response)) {
       return $response;
     }
+
     // Nothing to do if asset path is not configured.
     if (!$this->proxyManager->isConfigured(ProxyManagerInterface::ASSET_PATH)) {
       return $response;
     }
+
     $content = $response->getContent();
 
     if (!is_string($content)) {

tests/src/Unit/RedirectResponseSubscriberTest.php

@@ -59,6 +59,35 @@ public function testNoProxyDomain() : void {
     $sut->onResponse($event->reveal());
   }
 
+  /**
+   * Tests that response stays intact for non-get requests.
+   *
+   * @covers ::onResponse
+   * @covers ::__construct
+   */
+  public function testPostRequestResponse() : void {
+    $proxyManagerMock = $this->prophesize(ProxyManagerInterface::class);
+    $proxyManagerMock->isConfigured(ProxyManagerInterface::DEFAULT_PROXY_DOMAIN)
+      ->shouldBeCalled()
+      ->willReturn(TRUE);
+    $request = $this->prophesize(Request::class);
+    $request->isMethod('GET')
+      ->willReturn(FALSE);
+
+    $response = $this->prophesize(RedirectResponse::class);
+    $response->getTargetUrl()
+      ->shouldNotBeCalled();
+    $event = new ResponseEvent(
+      $this->createMock(HttpKernelInterface::class),
+      $request->reveal(),
+      HttpKernelInterface::MASTER_REQUEST,
+      $response->reveal()
+    );
+    // Make sure response stays intact when the request method is not GET.
+    $sut = new RedirectResponseSubscriber($proxyManagerMock->reveal(), ['www.hel.fi']);
+    $sut->onResponse($event);
+  }
+
   /**
    * Tests onResponse() with RedirectResponse.
    *
@@ -83,9 +112,13 @@ public function testRedirectResponse() : void {
     $response->getTargetUrl()
       ->willReturn('http://localhost:8888/test?x=1');
 
+    $request = $this->prophesize(Request::class);
+    $request->isMethod('GET')
+      ->willReturn(TRUE);
+
     $event = new ResponseEvent(
       $this->createMock(HttpKernelInterface::class),
-      $this->createMock(Request::class),
+      $request->reveal(),
       HttpKernelInterface::MASTER_REQUEST,
       $response->reveal()
     );
@@ -118,6 +151,9 @@ public function testResponseRedirect() : void {
     $request->getSchemeAndHttpHost()
       ->shouldBeCalled()
       ->willReturn('http://localhost:8888');
+    $request->isMethod('GET')
+      ->shouldBeCalled()
+      ->willReturn(TRUE);
     $request->getRequestUri()
       ->shouldBeCalled()
       ->willReturn('/test?x=1');