Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip AssetHttpMiddleware processing for JSON:API requests, never redirect POST requests #37

Merged
merged 6 commits into from
Apr 8, 2022

Conversation

tuutti
Copy link
Member

@tuutti tuutti commented Apr 5, 2022

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Apr 5, 2022

Codecov Report

Merging #37 (e511f13) into main (f5dcc53) will increase coverage by 53.92%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##               main      #37       +/-   ##
=============================================
+ Coverage     13.07%   67.00%   +53.92%     
- Complexity      115      124        +9     
=============================================
  Files            15       16        +1     
  Lines           283      300       +17     
=============================================
+ Hits             37      201      +164     
+ Misses          246       99      -147     
Impacted Files Coverage Δ
modules/contrib/helfi_proxy/src/ProxyTrait.php 53.33% <0.00%> (ø)
...src/EventSubscriber/RedirectResponseSubscriber.php 96.66% <0.00%> (+10.45%) ⬆️
...i_proxy/src/HttpMiddleware/AssetHttpMiddleware.php 56.41% <0.00%> (+24.83%) ⬆️
...les/contrib/helfi_proxy/src/Asset/CssOptimizer.php 26.66% <0.00%> (+26.66%) ⬆️
...ventSubscriber/TunnistamoRedirectUrlSubscriber.php 30.00% <0.00%> (+30.00%) ⬆️
...roxy/src/PathProcessor/SitePrefixPathProcessor.php 70.00% <0.00%> (+70.00%) ⬆️
modules/contrib/helfi_proxy/src/ProxyManager.php 86.25% <0.00%> (+86.25%) ⬆️
...ules/contrib/helfi_proxy/src/Selector/Selector.php 100.00% <0.00%> (+100.00%) ⬆️
...s/contrib/helfi_proxy/src/SessionConfiguration.php 100.00% <0.00%> (+100.00%) ⬆️
...rib/helfi_proxy/src/Selector/AttributeSelector.php 100.00% <0.00%> (+100.00%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5dcc53...e511f13. Read the comment docs.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 7, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@tuutti tuutti changed the title Skip processing for jsonapi Skip AssetHttpMiddleware processing for JSON:API requests, never redirect POST requests Apr 7, 2022
@tuutti tuutti merged commit 706cf9f into main Apr 8, 2022
@tuutti tuutti deleted the UHF-X-fix-jsonapi branch April 8, 2022 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants