Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UHF-8088: Fetch english external menus for alternative languages. #31

Merged
merged 8 commits into from
May 11, 2023
Merged

UHF-8088: Fetch english external menus for alternative languages. #31

merged 8 commits into from
May 11, 2023

Conversation

juho-lehmonen
Copy link
Contributor

@juho-lehmonen juho-lehmonen commented Apr 28, 2023 •
edited
Loading

UHF-8088

What was done

  • Modifies External Menu Block Base to fetch English external menu content on languages other than Finnish, Swedish and English

How to test

Designers review

  • This PR does not need designers review

Other PRs

This was referenced Apr 28, 2023
Merged
Merged
Merged
@juho-lehmonen juho-lehmonen changed the title Draft: UHF-8088: Fetch english external menus for alternative languages. UHF-8088: Fetch english external menus for alternative languages. Apr 28, 2023
@juho-lehmonen juho-lehmonen marked this pull request as ready for review April 28, 2023 12:12
tuutti
tuutti requested changes Apr 29, 2023
View reviewed changes
Copy link
Member

@tuutti tuutti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This exception needs a test. For example https://github.com/City-of-Helsinki/drupal-module-helfi-navigation/blob/main/tests/src/Functional/MenuBlockTest.php is pretty good place to test this

@juho-lehmonen
Copy link
Contributor Author

juho-lehmonen commented May 2, 2023 •
edited
Loading

This exception needs a test. For example https://github.com/City-of-Helsinki/drupal-module-helfi-navigation/blob/main/tests/src/Functional/MenuBlockTest.php is pretty good place to test this

Test added. Let me know if this test case is too simple or doesn't cover the exception well enough.

tuutti
tuutti approved these changes May 2, 2023
View reviewed changes
Copy link
Member

@tuutti tuutti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@juho-lehmonen juho-lehmonen force-pushed the UHF-8088-fallback-languages branch from 2a569b1 to 11bed22 Compare May 2, 2023 10:33
@sonarqubecloud
Copy link

sonarqubecloud bot commented May 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@juho-lehmonen juho-lehmonen merged commit 3f7575d into main May 11, 2023
@juho-lehmonen juho-lehmonen deleted the UHF-8088-fallback-languages branch May 11, 2023 05:25
This was referenced May 11, 2023
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rpnykanen rpnykanen rpnykanen approved these changes

@tuutti tuutti tuutti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@juho-lehmonen @tuutti @rpnykanen