Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UHF-8088: Add language attributes to header top and branding regions. #646

Merged
merged 5 commits into from
May 11, 2023
Merged

UHF-8088: Add language attributes to header top and branding regions. #646

merged 5 commits into from
May 11, 2023

Conversation

juho-lehmonen
Copy link
Contributor

@juho-lehmonen juho-lehmonen commented Apr 28, 2023 •
edited
Loading

UHF-8088

What was done

  • Added missing attributes to header top and heading branding regions
  • Added context to external mobile menu open and close buttons
  • Added language attributes to announcement nodes when fallback language content is displayed

How to test

Designers review

  • This PR does not need designers review

Other PRs

This was referenced Apr 28, 2023
Merged
Merged
@juho-lehmonen juho-lehmonen changed the title Draft: UHF-8088: Add language attributes to header top and branding regions. UHF-8088: Add language attributes to header top and branding regions. Apr 28, 2023
@juho-lehmonen juho-lehmonen marked this pull request as ready for review April 28, 2023 12:10
@juho-lehmonen juho-lehmonen force-pushed the UHF-8088-language-fallbacks branch from 87c880c to c97fa1f Compare May 2, 2023 09:46
@juho-lehmonen juho-lehmonen merged commit 8b90cf3 into main May 11, 2023
@juho-lehmonen juho-lehmonen deleted the UHF-8088-language-fallbacks branch May 11, 2023 05:24
This was referenced May 11, 2023
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rpnykanen rpnykanen rpnykanen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@juho-lehmonen @rpnykanen