Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UHF-10876 askem #384

Merged
merged 3 commits into from
Nov 25, 2024
Merged

UHF-10876 askem #384

merged 3 commits into from
Nov 25, 2024

Conversation

rpnykanen
Copy link
Contributor

@rpnykanen rpnykanen commented Nov 22, 2024 •
edited
Loading

UHF-10876

Since webform is only used with the custom-react-contact from which is being deleted, we can uninstall webform-module

What was done

Remove the original contact form.

How to install

  • Make sure your instance is up and running on correct branch.
    • git checkout UHF-10876
    • make fresh
  • Run make drush-cr

How to test

  • See that the site can be setup normally after webform-module was removed
  • Admin side should work without problems and status page should load.
  • Check that this feature works
  • Check that code follows our standards

@rpnykanen rpnykanen mentioned this pull request Nov 22, 2024
Merged
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

jeremysteerio
jeremysteerio reviewed Nov 25, 2024
View reviewed changes
Copy link
Contributor

@jeremysteerio jeremysteerio left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we handle existing webform submissions somehow?

Edit: resolved

@rpnykanen rpnykanen merged commit 2ed6a81 into dev Nov 25, 2024
2 checks passed
@rpnykanen rpnykanen deleted the UHF-10876 branch November 25, 2024 12:49
@rpnykanen rpnykanen restored the UHF-10876 branch December 16, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeremysteerio jeremysteerio jeremysteerio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rpnykanen @jeremysteerio