Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UHF-10892 Gin sidebar #364

Merged
merged 2 commits into from
Oct 25, 2024
Merged

UHF-10892 Gin sidebar #364

merged 2 commits into from
Oct 25, 2024

Conversation

khalima
Copy link
Contributor

@khalima khalima commented Oct 25, 2024 •
edited by jira bot
Loading

UHF-10892

What was done

How to install

  • Make sure your instance is up and running on correct branch.
    • git checkout UHF-10892
    • make fresh
  • Run make drush-cr

How to test

  • When adding/editing node, check that clicking the sidebar ⚙️ button actually works and it won't trigger an error like this:
    image
  • Check that code follows our standards

Other PRs

@khalima khalima mentioned this pull request Oct 25, 2024
Merged
2 tasks
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 25, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

teroelonen
teroelonen approved these changes Oct 25, 2024
View reviewed changes
Copy link
Contributor

@teroelonen teroelonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works 🦖

@khalima khalima merged commit f40125a into dev Oct 25, 2024
3 checks passed
@khalima khalima deleted the UHF-10892 branch October 25, 2024 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teroelonen teroelonen teroelonen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@khalima @teroelonen