Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UHF-10279 #325

Merged
merged 3 commits into from
Jul 11, 2024
Merged

UHF-10279 #325

merged 3 commits into from
Jul 11, 2024

Conversation

rpnykanen
Copy link
Contributor

@rpnykanen rpnykanen commented Jul 10, 2024 •
edited
Loading

UHF-10279

Solved a problem with jsonapi

What was done

Fixed the problem

How to install

  • Make sure your instance is up and running on correct branch.
    • git checkout UHF-10279
    • make fresh
  • Run make drush-cr
  • Setup IF-ui

How to test

  • During the build, there should be no errors, the build should finish successfully
  • Start browsing the frontend with network-tab open, keep an eye out for errors
    • Also check that there are no errors in the terminal where you ran yarn dev
  • Create new page, open it and there should be no errors.
  • Check the url's mentioned in the ticket and verify the change. Remember to test it with local url.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

teroelonen
teroelonen approved these changes Jul 11, 2024
View reviewed changes
Copy link
Contributor

@teroelonen teroelonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to work very nicely 🦖

@rpnykanen rpnykanen merged commit 2031b89 into dev Jul 11, 2024
2 checks passed
@rpnykanen rpnykanen deleted the UHF-10279 branch July 11, 2024 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teroelonen teroelonen teroelonen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rpnykanen @teroelonen