Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-10236: Accessibility fixes for search monitor #514

Merged
merged 1 commit into from
Jun 25, 2024
Merged

Conversation

teroelonen
Copy link
Contributor

@teroelonen teroelonen commented Jun 20, 2024

UHF-10236

What was done

  • Adjust focus styles for the job monitor. Other changes are in the hdbt PR.

How to install

  • Make sure your instance is up and running on correct branch.
    • git checkout UHF-10236
    • make fresh
  • composer require drupal/hdbt:dev-UHF-10236
  • Run make drush-cr

How to test

  • Go to https://helfi-rekry.docker.so/fi/avoimet-tyopaikat/etsi-avoimia-tyopaikkoja and make sure that the search monitor button that opens the search monitor says Open/Close the order form / Avaa/Sulje hakuvahti / Öppna/Stäng sökvakten depending on the language and state of the search monitor form.
  • Make sure that clicking the search monitor toggle button will also toggle aria-expaned attribute on the button correctly from false to true and back if the form is opened and then closed.
  • Fill in the form and submit it. Focus should now move to the "successful" messages title.
  • Refresh the page and fill in foo@bar to the email field and check the checkbox. Submit the form and you should now get an error notice and the focus should move to the notice.
  • Check that code follows our standards

Continuous documentation

  • This feature has been documented/the documentation has been updated
  • This change doesn't require updates to the documentation

Other PRs

Copy link

Copy link
Contributor

@sundflux sundflux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems to work

@sundflux sundflux merged commit 021bc22 into dev Jun 25, 2024
2 checks passed
@sundflux sundflux deleted the UHF-10236 branch June 25, 2024 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants