Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-10236: Accessibility fixes for search monitor #1016

Merged
merged 1 commit into from
Jun 25, 2024
Merged

UHF-10236: Accessibility fixes for search monitor #1016

merged 1 commit into from
Jun 25, 2024

Conversation

teroelonen
Copy link
Contributor

@teroelonen teroelonen commented Jun 20, 2024

UHF-10236

What was done

  • Added aria-expanded attribute for the search monitor toggle button.
    Change the text on the button to be more descriptive.
    Add focus change when ordering a new search monitor has succeeded of failed.

How to install

  • Check installation instructions from the Rekry PR

How to test

  • Check testing instructions from the Rekry PR
  • Check that code follows our standards.

Continuous documentation

  • This feature has been documented/the documentation has been updated
  • This change doesn't require updates to the documentation

Translations

  • Translations have been added to .po -files and included in this PR

Other PRs

Copy link

⚠️ Visual regression found! Please check if this change is wanted or accidental. You can check the output here: https://city-of-helsinki.github.io/drupal-hdbt/pull/1016/html_report/

Copy link
Contributor

@sundflux sundflux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants