Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecation error in views-view--job-listing-search.html.twig #388

Merged
merged 1 commit into from
Jan 9, 2024

Conversation

hyrsky
Copy link
Contributor

@hyrsky hyrsky commented Jan 9, 2024

What was done

Log files are spammed with following message:

Deprecated function: abs(): Passing null to parameter #1 ($num) of type int|float is deprecated in __TwigTemplate_[...]->doDisplay() (line 95 of /tmp/twig/[...]_views-view--job-listing-[...].php)

This should fix the deprecation message.

How to install

  • Make sure your instance is up and running on correct branch.
    • git checkout UHF-X-fix-deprecation-error
    • make fresh
  • Run make drush-cr

How to test

  • Check that this page works without JS enabled.

Log files are spammed with following message:
Deprecated function: abs(): Passing null to parameter #1 ($num) of type int|float is deprecated in __TwigTemplate_a50c131c592f73c06c175405fb05a903->doDisplay() (line 95 of \/tmp\/twig\/659d1db0ccb1e_views-view--job-listing-s_znAVFe4YirBkQ_LpLSJME5eiO\/XkctdSAE01NPFXVKj5fZW-_T-UvHDkkE39mbf3EmiOc.php)
Copy link

sonarqubecloud bot commented Jan 9, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@hyrsky hyrsky marked this pull request as ready for review January 9, 2024 13:35
@hyrsky hyrsky merged commit 88790cb into dev Jan 9, 2024
1 check passed
@hyrsky hyrsky deleted the UHF-X-fix-deprecation-error branch January 9, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants