Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-9067: Add term changes hardcoded unit searches #541

Merged
merged 4 commits into from
Jan 16, 2024
Merged

Conversation

teroelonen
Copy link
Contributor

@teroelonen teroelonen commented Jan 9, 2024

UHF-9067

What was done

How to install

  • Make sure your instance is up and running on correct branch.
    • git checkout UHF-9067
    • make fresh
  • Update the hdbt-theme
    • composer require drupal/hdbt:dev-UHF-9067
  • Run make drush-cr drush-cim drush-locale-update drush-cr

How to test

  • Check that the labels are as specified in the tickets AC (long table) on all the searches listed above on all three languages.
    • Kasko
    • Sote
    • Kuva
    • Kanslia
  • Check empty texts for the searches that can get no results. If you get 0 results there should be title and a text. The title should say No results and the focus should move to it once the search is conducted. The descriptive text should say No results were found for the criteria you entered. Try changing your search criteria.. Translations for the empty text should be for Finnish Ei hakutuloksia and Antamillasi valinnoilla ei löytynyt tuloksia. Voit kokeilla muuttaa hakuehtojasi. and for Swedish Inga sökresultat and Med dina val hittades inga resultat. Du kan försöka ändra dina sökvillkor.. (This is part of task UHF-9111 but there is no point in having the update_hook to run twice so added this here).
  • Check that on the high school search the tabs for switching between list and map view are similar to the ones used in Peruskouluhaku
  • Check the other PRs listed below.
  • Check that code follows our standards

Designers review

  • This PR does not need designers review
  • This PR has been visually reviewed by a designer (Name of the designer)

Other PRs

…yground and after school activity search result labels
Copy link
Contributor

@Arkkimaagi Arkkimaagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, well done on this complex matter. 🍰

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions

39.4% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@teroelonen teroelonen merged commit b91e7e8 into dev Jan 16, 2024
1 of 2 checks passed
@teroelonen teroelonen deleted the UHF-9067 branch January 16, 2024 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants