Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-10908 FunctionalJS test for cookie banner #861

Merged
merged 22 commits into from
Dec 12, 2024
Merged
Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
12030cd
Revert "UHF-10908: Reverted the changes for functional cookie banner …
khalima Dec 10, 2024
d068cc3
UHF-10908: Merge branch 'main' of https://github.com/City-of-Helsinki…
khalima Dec 10, 2024
2e4b7fd
UHF-10908: Merge branch 'main' of https://github.com/City-of-Helsinki…
khalima Dec 10, 2024
647498b
UHF-10908: Support for functional js tests
tuutti Dec 10, 2024
932cb5a
UHF-10908: Run as root
tuutti Dec 10, 2024
b30e98d
UHF-10908: Use updated test image
tuutti Dec 10, 2024
c27db4e
UHF-10908: Set user
tuutti Dec 10, 2024
3d92dc3
UHF-10908: Use ci images again
tuutti Dec 10, 2024
ce65b72
UHF-10908: Use local image again
tuutti Dec 10, 2024
e4089eb
UHF-10908: Test 8.3
tuutti Dec 10, 2024
b1cbe26
UHF-10908: Debug
tuutti Dec 10, 2024
dce37b2
UHF-10908: Empty commit to trigger test
tuutti Dec 10, 2024
632cbe9
UHF-10908: Override entrypoint
tuutti Dec 10, 2024
7a6774e
UHF-10908: Testing
tuutti Dec 10, 2024
098f5c6
UHF-10908: Install drupal after lint checks
tuutti Dec 11, 2024
b44c917
UHF-10908: Correct webroot
tuutti Dec 11, 2024
7839a69
UHF-10908: Fixed env variable
tuutti Dec 11, 2024
2e36014
Update CookieBannerTest.php
khalima Dec 12, 2024
a62b560
UHF-10908: Merge branch 'main' of https://github.com/City-of-Helsinki…
khalima Dec 12, 2024
146ff07
UHF-10908: Fixed translations for the views pager to prevent race con…
khalima Dec 12, 2024
17fd4ee
Revert "UHF-10908: Fixed translations for the views pager to prevent …
khalima Dec 12, 2024
aa91b08
UHF-10908: Reverted helfi_platform to main branch.
khalima Dec 12, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
UHF-10908: Merge branch 'main' of https://github.com/City-of-Helsinki…
khalima committed Dec 10, 2024
commit 2e4b7fdafd68e831bb0a0365006249b3dacab3b1
9 changes: 1 addition & 8 deletions modules/hdbt_cookie_banner/assets/js/hdbt-cookie-banner.js
Original file line number Diff line number Diff line change
@@ -87,16 +87,9 @@ class UnapprovedItemError extends Error {
const name = `Unapproved ${storageType}`
const message = `Found: ${sortedKeys.join(', ')}`

class UnapprovedItemError extends Error {
constructor(message) {
super(message)
this.name = name
}
}

// Capture the error with Sentry and send a message with the
// unapproved items so that they can be searched in Sentry.
window.Sentry.captureException(new UnapprovedItemError(message), {
window.Sentry.captureException(new UnapprovedItemError(message, name), {
level: 'warning',
tags: {
approvedCategories: acceptedGroups.join(', '),
You are viewing a condensed version of this merge commit. You can view the full changes here.