Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-10908 FunctionalJS test for cookie banner #861

Merged
merged 22 commits into from
Dec 12, 2024
Merged

UHF-10908 FunctionalJS test for cookie banner #861

merged 22 commits into from
Dec 12, 2024

Conversation

khalima
Copy link
Contributor

@khalima khalima commented Dec 4, 2024

UHF-10908

What was done

  • Use variable for the spacerParentSelector, if it is set.
  • Added hdbt_cookie_banner_test module to alter settings in tests.
  • Added test for the cookie banner functionality.

How to install

  • Make sure your instance is up and running on latest dev branch.
    • git pull origin dev
    • make fresh
  • Update the Helfi Platform config
    • composer require drupal/helfi_platform_config:dev-UHF-10908
  • Run make drush-updb drush-cr

How to test

  • Add testing profile to your instance .env file:
    COMPOSE_PROFILES=testing
  • Get the drush server up and running. In the container (make shell) run:
    drush runserver https://app &
  • Run the test
    vendor/bin/phpunit -c /app/phpunit.xml.dist public/modules/contrib/helfi_platform_config/modules/hdbt_cookie_banner/tests/src/FunctionalJavascript
  • Check that code follows our standards

@khalima khalima marked this pull request as ready for review December 10, 2024 06:22
@codecov-commenter
Copy link

codecov-commenter commented Dec 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 17.87%. Comparing base (6c57a10) to head (aa91b08).
Report is 107 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #861      +/-   ##
============================================
+ Coverage     14.49%   17.87%   +3.37%     
- Complexity      271      285      +14     
============================================
  Files            33       36       +3     
  Lines          1035     1080      +45     
============================================
+ Hits            150      193      +43     
- Misses          885      887       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@khalima khalima merged commit f096789 into main Dec 12, 2024
3 checks passed
@khalima khalima deleted the UHF-10908 branch December 12, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants