Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UHF-10239: Adds image gallery paragraph #840

Merged
merged 26 commits into from
Nov 18, 2024
Merged

UHF-10239: Adds image gallery paragraph #840

merged 26 commits into from
Nov 18, 2024

Conversation

annadruid
Copy link
Contributor

@annadruid annadruid commented Nov 7, 2024 •
edited
Loading

UHF-10239

What was done

  • Configurations for the new image gallery paragraph
  • New image style configurations required by the image gallery paragraph
  • Translations for the image gallery paragraph validation
  • Added a missing translation for hero validation which I noticed while adding image gallery translations.

How to install

  • Make sure your instance is up and running on latest dev branch.
    • git pull origin dev
    • make fresh
  • Update the Helfi Platform config
    • composer require drupal/helfi_platform_config:dev-UHF-10239
  • Run make drush-updb drush-cr

How to test

  • The functionality testing guidance is in HDBT pr
  • Check that code follows our standards

Continuous documentation

  • This feature has been documented/the documentation has been updated
  • This change doesn't require updates to the documentation

Translations

  • Translations have been added to .po -files and included in this PR

Other PRs

@annadruid annadruid marked this pull request as draft November 7, 2024 08:40
Anna Lonka and others added 17 commits November 8, 2024 07:48
UHF-10239: Enables module, adds it to page templates
48a23b4
UHF-10239: Fixed function name
0d39f69
@annadruid
UHF-10239: Fixed filenames
edfc071
@annadruid
UHF-10239: Removed unnecessary photographer config
38d7d14
@annadruid
UHF-10239: Fixed linter errors
5e6f7a0
@annadruid
UHF-10239: Fixed linter errors
5464de8
@annadruid
UHF-10239: Config changes and return stype fix
1f5a9c1
@annadruid
UHF-10239: Return type fix
b4a4d61
@annadruid
UHF-10239: Adds image styles and moved language configs to correct place
1ea9e26
@annadruid
UHF-10239: Added validation for image gallery
ce64ad1
@annadruid
UHF-10239: Fixed image dependecy
f8bb546
@annadruid
UHF-10239: Fixed image dependecy
075e5b4
@annadruid
UHF-10239: Added update function to re-import helfi_media configs
e0e4355
@annadruid
UHF-10239: Added update function to re-import hefi_image_styles configs
302819b
@annadruid
UHF-10239: Fixed config
dcbba9d
@annadruid
UHF-10239: Fixed langcodes and added missing config
2758fe6
@annadruid
UHF-10239: Fixed linter errors
b77ae44
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 16.71%. Comparing base (bb50a52) to head (b77ae44).
Report is 253 commits behind head on main.

Additional details and impacted files 
@@             Coverage Diff              @@
##               main     #840      +/-   ##
============================================
+ Coverage     15.29%   16.71%   +1.42%     
- Complexity      259      271      +12     
============================================
  Files            31       33       +2     
  Lines           981     1035      +54     
============================================
+ Hits            150      173      +23     
- Misses          831      862      +31

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@annadruid annadruid mentioned this pull request Nov 14, 2024
Merged
13 tasks
@annadruid annadruid marked this pull request as ready for review November 14, 2024 12:44
teroelonen
teroelonen requested changes Nov 15, 2024
View reviewed changes
Copy link
Contributor

@teroelonen teroelonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pending the image style changes that I wrote to you on chat. Otherwise looks very good to me!

@annadruid
Copy link
Contributor Author

Pending the image style changes that I wrote to you on chat. Otherwise looks very good to me!

The image styles have now been updated!

@annadruid annadruid mentioned this pull request Nov 18, 2024
Merged
6 tasks
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@annadruid annadruid mentioned this pull request Nov 18, 2024
Merged
5 tasks
teroelonen
teroelonen approved these changes Nov 18, 2024
View reviewed changes
Copy link
Contributor

@teroelonen teroelonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really great work with this one! 🦖

@annadruid annadruid merged commit 45e879f into main Nov 18, 2024
4 checks passed
@annadruid annadruid deleted the UHF-10239 branch November 18, 2024 15:26
This was referenced Nov 18, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teroelonen teroelonen teroelonen approved these changes

@tuutti tuutti tuutti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@annadruid @codecov-commenter @tuutti @teroelonen @khalima