Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-10239 Image gallery paragraph #1110

Merged
merged 12 commits into from
Nov 18, 2024
Merged

UHF-10239 Image gallery paragraph #1110

merged 12 commits into from
Nov 18, 2024

Conversation

annadruid
Copy link
Contributor

@annadruid annadruid commented Nov 14, 2024

UHF-10239

What was done

  • Created an image gallery paragraph which can be added to basic page upper and lower content areas as well as landing page.

How to install

  • Make sure your instance is up and running on latest dev branch.
    • git pull origin dev
    • make fresh
  • Update the HDBT theme
    • composer require drupal/hdbt:dev-UHF-10239
  • Update the Helfi Platform config
    • composer require drupal/helfi_platform_config:dev-UHF-10239
  • Update the HDBT Admin theme
    • composer require drupal/hdbt_admin:dev-UHF-10239
  • Run make drush-updb drush-cr

How to test

  • The image gallery should be automatically be added to basic page upper and lower content areas and on landing page to the content area. Make sure it's available in all three. The image gallery will be added to instance related content types in separate pr:s after HDBT and platform config have been merged.
  • Add image galleries to a basic page and add different variations to upper and lower content areas.
  • Make sure that in the upper area there are two images next to each other and in the lower area there are three
  • Try out the different aspect ratios of the image gallery
  • Test that the photographer comes from the image media entity below the image.
  • Test that the design is responsive and works in each breakpoint
  • Try out translating the paragraph, it should work normally
  • Test that the validation works, meaning there should be at least two gallery items always. It should give an error if there's only one item in a galley.
  • Check that code follows our standards

In etusivu instance:

  • Test that image gallery is available in news content type (see instructions on etusivu pr)

In KYMP

  • Test that image gallery is available in district content type (see instructions on kymp pr)

Continuous documentation

  • This feature has been documented/the documentation has been updated
  • This change doesn't require updates to the documentation

Translations

  • [ x] Translations have been added to .po -files and included in this PR

Other PRs

@annadruid annadruid marked this pull request as ready for review November 14, 2024 12:44
Copy link

⚠️ Visual regression found! Please check if this change is wanted or accidental. You can check the output here: https://city-of-helsinki.github.io/drupal-hdbt/pull/1110/html_report/

@annadruid annadruid changed the title UHF-10239 UHF-10239 Image gallery paragraph Nov 14, 2024
Copy link

⚠️ Visual regression found! Please check if this change is wanted or accidental. You can check the output here: https://city-of-helsinki.github.io/drupal-hdbt/pull/1110/html_report/

1 similar comment
Copy link

⚠️ Visual regression found! Please check if this change is wanted or accidental. You can check the output here: https://city-of-helsinki.github.io/drupal-hdbt/pull/1110/html_report/

Copy link

⚠️ Visual regression found! Please check if this change is wanted or accidental. You can check the output here: https://city-of-helsinki.github.io/drupal-hdbt/pull/1110/html_report/

Copy link

⚠️ Visual regression found! Please check if this change is wanted or accidental. You can check the output here: https://city-of-helsinki.github.io/drupal-hdbt/pull/1110/html_report/

Copy link
Contributor

@teroelonen teroelonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might need small adjusting but looks really good so far!

src/scss/06_components/paragraphs/_image-gallery.scss Outdated Show resolved Hide resolved
Copy link

⚠️ Visual regression found! Please check if this change is wanted or accidental. You can check the output here: https://city-of-helsinki.github.io/drupal-hdbt/pull/1110/html_report/

Copy link
Contributor

@teroelonen teroelonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is nice 🦖

Copy link

⚠️ Visual regression found! Please check if this change is wanted or accidental. You can check the output here: https://city-of-helsinki.github.io/drupal-hdbt/pull/1110/html_report/

@annadruid annadruid merged commit 788a852 into main Nov 18, 2024
2 checks passed
@annadruid annadruid deleted the UHF-10239 branch November 18, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants