Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-7650: Fix neuvonta chat compatibility with disable-genesys-chat #568

Merged
merged 1 commit into from
Aug 23, 2023

Conversation

jeremysteerio
Copy link
Contributor

@jeremysteerio jeremysteerio commented Aug 22, 2023

UHF-7650

Make chat open button available for the helsinki-info page (again).

What was done

Added logic to check if disable-genesys-button has disabled the chat button and replace it with the open chat button.

How to install

  • Boot up strategia instance (https://github.com/City-of-Helsinki/drupal-helfi-strategia/)
  • Make sure your instance is up and running on latest dev branch.
    • git pull origin dev
    • make fresh
  • Update the Helfi Platform config
    • composer require drupal/helfi_platform_config:dev-UHF-7650-helsinki-info-button
  • Update HDBT
    • composer require drupal/hdbt:dev-UHF-7650-helsinki-info-button
  • Run make drush-cr

How to test

  • If you ran make fresh, you should be able to navigate to this page: https://strategia.docker.so/fi/paatoksenteko-ja-hallinto/ota-yhteytta/helsinki-info
  • Edit the page, specifically the first 50/50 paragraph containing a text paragraph
  • Edit the html to include an element with an id of openChat (as in something like <a id="openChat">Avaa chat</a>)
  • Load the page. You should see a button element where you added the element.
  • Clicking on the button should pop the neuvonta chat open.

Other PRs

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov-commenter
Copy link

codecov-commenter commented Aug 22, 2023

Codecov Report

Merging #568 (24c3cb1) into main (a44de27) will not change coverage.
Report is 4 commits behind head on main.
The diff coverage is n/a.

❗ Current head 24c3cb1 differs from pull request most recent head fe10bd7. Consider uploading reports for the commit fe10bd7 to get more accurate results

@@            Coverage Diff            @@
##               main     #568   +/-   ##
=========================================
  Coverage     12.74%   12.74%           
  Complexity      236      236           
=========================================
  Files            30       30           
  Lines           902      902           
=========================================
  Hits            115      115           
  Misses          787      787           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@xkhaven xkhaven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and works as intended.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants