Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UHF-7650: Fix helsinki info button #751

Merged
merged 1 commit into from
Aug 23, 2023
Merged

UHF-7650: Fix helsinki info button #751

merged 1 commit into from
Aug 23, 2023

Conversation

jeremysteerio
Copy link
Contributor

@jeremysteerio jeremysteerio commented Aug 22, 2023 •
edited by jira bot
Loading

UHF-7650

Make button on helsinki info pages usable again.

What was done

  • Added ID to genesys-disabled message to make it replaceable from the neuvonta chat script. Neuvonta script loads genesys from external source and seems that global _genesys object is never available when the disable-genesys-button script executes.
  • Updated caniuse-lite

How to install & test:

  • Check instructions here:

@jeremysteerio jeremysteerio mentioned this pull request Aug 22, 2023
Merged
xkhaven
xkhaven approved these changes Aug 23, 2023
View reviewed changes
Copy link
Contributor

@xkhaven xkhaven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@jeremysteerio jeremysteerio merged commit b431384 into main Aug 23, 2023
@jeremysteerio jeremysteerio deleted the UHF-7650-helsinki-info-button branch August 23, 2023 11:08
This was referenced Aug 24, 2023
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xkhaven xkhaven xkhaven approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeremysteerio @xkhaven