Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UHF-8525: Removed cron based cache invalidation in favor of automatic PubSub based cache invalidation #518

Merged
merged 6 commits into from
Sep 12, 2023
Merged

UHF-8525: Removed cron based cache invalidation in favor of automatic PubSub based cache invalidation #518

merged 6 commits into from
Sep 12, 2023

Conversation

tuutti
Copy link
Member

@tuutti tuutti commented May 26, 2023 •
edited by teroelonen
Loading

UHF-8525

What was done

  • This thing was fixed

How to install

  • Make sure your instance is up and running on latest dev branch.
    • git pull origin dev
    • make fresh
  • Update the Helfi Platform config
    • composer require drupal/helfi_platform_config:dev-UHF-0000_insert_correct_branch
  • Run make drush-updb drush-cr

How to test

  • Check that this feature works
  • Check that code follows our standards

Other PRs

  • Link to other PR

@tuutti tuutti mentioned this pull request May 26, 2023
Merged
@tuutti tuutti mentioned this pull request May 29, 2023
Merged
9 tasks
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov-commenter
Copy link

codecov-commenter commented Aug 31, 2023 •
edited
Loading

Codecov Report

Merging #518 (f0d1bde) into main (aaeb706) will not change coverage.
The diff coverage is n/a.

❗ Current head f0d1bde differs from pull request most recent head f07714f. Consider uploading reports for the commit f07714f to get more accurate results

@@            Coverage Diff            @@
##               main     #518   +/-   ##
=========================================
  Coverage     12.74%   12.74%           
  Complexity      236      236           
=========================================
  Files            30       30           
  Lines           902      902           
=========================================
  Hits            115      115           
  Misses          787      787

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

teroelonen
teroelonen approved these changes Sep 11, 2023
View reviewed changes
Copy link
Contributor

@teroelonen teroelonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be good 🦖

@tuutti tuutti merged commit 0996210 into main Sep 12, 2023
@tuutti tuutti deleted the UHF-8525 branch September 12, 2023 05:59
@tuutti tuutti restored the UHF-8525 branch September 12, 2023 06:30
This was referenced Sep 12, 2023
Merged
Merged
This was referenced Sep 12, 2023
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teroelonen teroelonen teroelonen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tuutti @codecov-commenter @teroelonen