Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-8525: Flush external caches when global announcement is modified #374

Merged
merged 8 commits into from
Sep 18, 2023

Conversation

tuutti
Copy link
Member

@tuutti tuutti commented May 26, 2023

UHF-8525

What was done

How to install

  • Make sure your instance is up and running on correct branch.
    • git checkout UHF-8525
  • Update platform config: composer require drupal/helfi_platform_config:dev-UHF-8525
  • Run make drush-cr

How to test

  • Start some other project (Liikenne for example)
  • Add $config['helfi_global_announcement.settings']['source_environment'] = 'local'; to your local.settings.php (on Liikenne)
  • Add PubSub access key configuration to your local.settings.php file (in both projects): https://helsinkisolutionoffice.atlassian.net/wiki/spaces/HEL/pages/8354005224/Tunnusten+salasanojen+ja+muiden+avainten+jakaminen
  • Start PubSub listener on Liikenne drush helfi:azure:pubsub-listen
  • Create a new announcement node and check the Publish on external site checkbox (on Etusivu)
  • Test that the global announcement is visible on Liikenne
  • Update the announcement node with something
  • Make sure Liikenne receives a pubsub message like
Received message [#2]: {"type":"message","from":"group","fromUserId":null,"group":"invalidate_cache","dataType":"json","data":{"tags":["helfi_external_entity_announcement"],"timestamp":1685336769}}`
  • Make sure the global announcement block cache is flushed

Other PRs

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@tuutti tuutti changed the title UHF-8525: Flush external caches when global announcement is modified/updated or created UHF-8525: Flush external caches when global announcement is modified May 29, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@teroelonen teroelonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This worked good 🦖

@tuutti tuutti merged commit 97ffcb4 into dev Sep 18, 2023
@tuutti tuutti deleted the UHF-8525 branch September 18, 2023 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants