Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UHF-6666: Search filters #371

Closed
wants to merge 56 commits into from
Closed

UHF-6666: Search filters #371

wants to merge 56 commits into from

Conversation

jeremysteerio
Copy link
Contributor

@jeremysteerio jeremysteerio commented Oct 3, 2022 •
edited by sakkelaaksonen-siili
Loading

UHF-6666: Search filters

Added filters to LinkedEvents React-version

What was done

  • Added filters according to specs
  • Filters rendered conditionally based on paragraph choices
  • Selecting stuff from filters and submitting creates an API call to LinkedEvents and renders results

How to install

  • Get any instance up and running
  • Get this branch: composer require drupal/helfi_platform_config:dev-UHF-6666-search-filters
  • Get the style branch for HDBT: composer require drupal/hdbt:dev-UHF-3128-sote-linkedevents-filtering
  • Run make drush-updb
  • Run make drush-cr

How to test

  • Create or edit a landing- or standard page.
  • Add an Events paragraph. Fill fields.
    • API URL = https://tapahtumat.hel.fi/fi/events?text=jooga
  • Visit the page.
  • Test the filters:
    • Changing filter values shouldn't execute search, only clicking the submit button
    • Test that filters work as expected
  • "Lataa lisää" will be removed. At this point, only 5 first events will be shown, regadless of result count. This will be handled later with Pagination component.

Other PRs

ltpk-siili and others added 24 commits September 23, 2022 12:23
@ltpk-siili
UHF-6665: added new fields to the events paragraph
291204a
@ltpk-siili
UHF-6665: added disable_field dependency
4402443
@ltpk-siili
UHF-6665: added disable_field to composer.json
7160b27
@ltpk-siili
UHF-6665: typo fix in version string
477254a
@jeremysteerio
Add listing events in React
fdc0dc9
@ltpk-siili
UHF-6665: removed the info text field & added info to other fields
8352494
@jeremysteerio
Fix coding style
f7f3f91
@jeremysteerio
Remove i18next
c6cc9c2
@jeremysteerio
Remove unused exports
94dd6c6
@jeremysteerio
Remove unused import
9d9b2be
@jeremysteerio
Merge pull request #365 from City-of-Helsinki/UHF-6668-linkedevents-r…
9368db7 
…eact-results

UHF-6668 Add listing events in React
@jeremysteerio
Merge pull request #363 from City-of-Helsinki/UHF-6665_linkedevents_b…
e660617 
…ackend_changes

UHF-6665: LinkedEvents backend changes
@jeremysteerio
UHF-6666: Add search filters for React version of LinkedEvents
26288cd
@jeremysteerio
Change default result size to 5
0a7fe09
@jeremysteerio
Delete old script
03d1f20
@jeremysteerio
Add reading events URL value from data-attribute rather than global v…
6209c57 
…ariable
@jeremysteerio
UHF-6666: Move filter to own components
fa3170f
@jeremysteerio
Styling fixes
fc2e4f1
@jeremysteerio
Update index.html for larger amount of results
3f481d7
@jeremysteerio
Style changes
dbca7bc
@jeremysteerio
Updat e index.html to reflect backend changes
d1c1c4c
@jeremysteerio
Add conditional rendering based on props
329fdec
@jeremysteerio
Add exposing backend choices to twig template
7eff404
@jeremysteerio
Fix end date parameter when using the same date for both dates
1b1437d
@sakkelaaksonen-siili sakkelaaksonen-siili self-assigned this Oct 3, 2022
@sakkelaaksonen-siili
Copy link

Alku- ja loppupäivämäärän poistaminen näppäimistöllä kaataa koko react-palikan.

Aseta alku- ja loppupäivämäärä.
Poista alku- tai loppupäivämäärä näppäimistöllä. Paina vaikka backspacea , hitaasti, yksi kerrallaan, kunnes saat.

"Uncaught RangeError: Invalid time value"

@sakkelaaksonen-siili
Copy link

Jos kaikki filtterit laittaa pois päältä, Filter Events -otsikko on silti näkyvillä

@sakkelaaksonen-siili
Copy link

Tuloksia tulee aina vain viisi, vaikka sanoo että tulis 30 tai mitä vaan. Onko paginaatiota olemassa tässä ollenkaan?

@sakkelaaksonen-siili
Copy link

päivämääriä ei voi vaihtaa kirjoittamalla koska koko roska kaatuu kun päiuvämäärän validointia ei hanskata ollenkaan. mutta kenttä silti antaa kirjoittaa.

ltpk-siili and others added 23 commits October 11, 2022 12:19
@ltpk-siili @sakkelaaksonen-siili
UHF-6665: added disable_field dependency
1ea0149
@ltpk-siili @sakkelaaksonen-siili
UHF-6665: added disable_field to composer.json
82cb0c9
@ltpk-siili @sakkelaaksonen-siili
UHF-6665: typo fix in version string
0983f70
@ltpk-siili @sakkelaaksonen-siili
UHF-6665: removed the info text field & added info to other fields
a14822a
@jeremysteerio @sakkelaaksonen-siili
UHF-6666: Add search filters for React version of LinkedEvents
cea5ad2
@jeremysteerio @sakkelaaksonen-siili
Change default result size to 5
7e7b9e9
@jeremysteerio @sakkelaaksonen-siili
Delete old script
93f9f4d
@jeremysteerio @sakkelaaksonen-siili
Add reading events URL value from data-attribute rather than global v…
42d5a11 
…ariable
@jeremysteerio @sakkelaaksonen-siili
UHF-6666: Move filter to own components
c73ed64
@jeremysteerio @sakkelaaksonen-siili
Styling fixes
857eabc
@jeremysteerio @sakkelaaksonen-siili
Update index.html for larger amount of results
cd28f39
@jeremysteerio @sakkelaaksonen-siili
Style changes
4323d3e
@jeremysteerio @sakkelaaksonen-siili
Updat e index.html to reflect backend changes
05fafcc
@jeremysteerio @sakkelaaksonen-siili
Add conditional rendering based on props
57091c6
@jeremysteerio @sakkelaaksonen-siili
Add exposing backend choices to twig template
c978019
@jeremysteerio @sakkelaaksonen-siili
Fix end date parameter when using the same date for both dates
a3e7c9e
@jeremysteerio @sakkelaaksonen-siili
UHF-6666: Fix logic for getting event list paragraph values
0c8445f
@sakkelaaksonen-siili
date input validations added. SWR added to datalayer to prevent conte…
28c947f 
…nt flashes and continuous refetching
@sakkelaaksonen-siili
revert error test url in index.html
41f5425
@sakkelaaksonen-siili
Merge branch 'UHF-6666-search-filters' of github.com:City-of-Helsinki…
1af9f6b 
…/drupal-helfi-platform-config into UHF-6666-search-filters
@sakkelaaksonen-siili
better build script. fixed validation. Better types. Cleanup for peer…
fb8b4fe 
… review
@sakkelaaksonen-siili
remove sourcemap from build
9a09be2
@sakkelaaksonen-siili
remove previous build file
1754d57
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 6 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sakkelaaksonen-siili sakkelaaksonen-siili force-pushed the UHF-3128-sote-linkedevents-filtering branch from b406142 to dda5eda Compare October 12, 2022 11:33
@sakkelaaksonen-siili sakkelaaksonen-siili marked this pull request as draft October 12, 2022 13:05
@rpnykanen rpnykanen deleted the UHF-6666-search-filters branch February 13, 2023 07:02
@rpnykanen rpnykanen restored the UHF-6666-search-filters branch February 13, 2023 07:02
@khalima khalima deleted the UHF-6666-search-filters branch May 24, 2023 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sakkelaaksonen-siili sakkelaaksonen-siili

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jeremysteerio @sakkelaaksonen-siili @ltpk-siili