UHF-6668 Add listing events in React #365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremysteerio
changed the title
Jussiles
approved these changes
Sep 28, 2022
| "i18next-browser-languagedetector": "^6.1.2", | ||
| "react": "^17.0.2", | ||
| "react-dom": "^17.0.2", | ||
| "react-i18next": "^11.7.3", |
There was a problem hiding this comment.
Maybe i18next packages could be moved if you're not using those.
| }) | ||
| .catch(e => setFailed(true)) | ||
| .finally(() => setLoading(false)) | ||
| ; |
| street_address?: MultilingualString | ||
| }; | ||
|
|
||
| export default Event; |
There was a problem hiding this comment.
Maybe not every type needs to exported if not imported in other files. Also Event has double export.
jeremysteerio
changed the base branch from
main
to
UHF-3128-sote-linkedevents-filtering
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Events list in React UHF-6668
First step in 'Reactifying' the events paragraph
What was done
How to install
composer require drupal/helfi_platform_config:dev-UHF-6668-linkedevents-react-resultscomposer reinstall drupal/hdbt --prefer-sourcecd public/theme/contrib/hdbtgit cherry-pick 02ceb46c8fbbf81447d3a7b19a5738a38b5a3b30drush-creventsparagraph to a landing or standard pageHow to test